Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: should use Lock when mutating the flag #1141

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

pratikspatil024
Copy link
Member

Description

Cherry-picks @zhiqiangxu's commits from #1120.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c629c0f) 55.98% compared to head (76db8bb) 56.00%.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           v1.2.3-candidate    #1141      +/-   ##
====================================================
+ Coverage             55.98%   56.00%   +0.02%     
====================================================
  Files                   658      658              
  Lines                114476   114468       -8     
====================================================
+ Hits                  64087    64109      +22     
+ Misses                46536    46504      -32     
- Partials               3853     3855       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pratikspatil024 pratikspatil024 merged commit c559619 into v1.2.3-candidate Jan 22, 2024
12 checks passed
@pratikspatil024 pratikspatil024 deleted the block-stm-bug-fix branch January 22, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants