fix bug: should use Lock when mutating the flag #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zhiqiangxu
commented
Jan 5, 2024
•
zhiqiangxu
commented
- hold the write lock while mutating
- hold the read lock while reading, otherwise the result may be inconsistent(partially updated)
…lag-fix Fix ParallelSpeculativeProcesses flag
…nto v1.2.0-beta-candidate
…ndidate Geth merge v1.12.2
Pruning Bug Fix
* chg: bump some deps for sec vulsn * chg: use newer matic-cli and node version
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
- Coverage 55.97% 55.91% -0.07%
==========================================
Files 658 658
Lines 114435 114427 -8
==========================================
- Hits 64056 63977 -79
- Misses 46527 46604 +77
+ Partials 3852 3846 -6 ☔ View full report in Codecov by Sentry. |
cffls
approved these changes
Jan 18, 2024
marcello33
approved these changes
Jan 18, 2024
pratikspatil024
approved these changes
Jan 19, 2024
pratikspatil024
changed the base branch from
master
to
arpit/v1.2.2-beta-candidate
temaniarpit27
changed the base branch from
arpit/v1.2.2-beta-candidate
to
develop
This was referenced Jan 22, 2024
|
Cherry-picked the 3 commits from @zhiqiangxu into #1141. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.