Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

style: Order column-count before column-gap #2395

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Conversation

kfranqueiro
Copy link
Contributor

IMO it makes no sense to require column-count after other CSS columns properties; column count is the most pertinent bit of information (and sometimes is the rule that makes it evident that something is even using CSS columns to begin with) and putting it first should make other columns properties more readable.

@codecov-io
Copy link

codecov-io commented Mar 14, 2018

Codecov Report

Merging #2395 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2395   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files         100      100           
  Lines        4144     4144           
  Branches      535      535           
=======================================
  Hits         4098     4098           
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24480c...e643b68. Read the comment docs.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It makes more sense to me to declare the number of columns before specifying gap/fill/span properties.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kfranqueiro kfranqueiro merged commit 30a29f6 into master Mar 14, 2018
@kfranqueiro kfranqueiro deleted the stylelint-column-count branch March 14, 2018 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants