This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
feat(image-list): Add Masonry Image List #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonniezhou
approved these changes
Mar 13, 2018
packages/mdc-image-list/README.md
Outdated
| ```html | ||
| <ul class="mdc-image-list mdc-image-list--masonry my-masonry-image-list"> | ||
| <li class="mdc-image-list__item"> | ||
| <img class="mdc-image-list__image" src="images/1-1.jpg"> |
There was a problem hiding this comment.
nit: Use src="..." to be consistent with above
There was a problem hiding this comment.
Oh jeez. that's not a nit, that's a "you copypasta'd from the demo you goof." I am ashamed.
packages/mdc-image-list/README.md
Outdated
| @@ -91,12 +124,16 @@ Mixin | Description | |||
| --- | --- | |||
| `mdc-image-list-aspect($width-height-ratio)` | Styles the aspect container elements within an Image List to conform to the given ratio, where 1 is 1:1, greater than 1 is wider, and less than 1 is taller. | |||
| `mdc-image-list-standard-columns($column-count, $gutter-size)` | Styles a Standard Image List to display the given number of columns. `$gutter-size` is optional and overrides the default amount of space between items. | |||
| `mdc-image-list-masonry-columns($column-count, $gutter-size)` | Styles a Masonry Image List to display the given number of columns. `$gutter-size` is optional and overrides the default amount of space between items. | |||
|
|
|||
| > **Note:** Only one of the `-columns` mixins should be used for any given Image List. Use the mixin appropriate to the | |||
There was a problem hiding this comment.
nit: Use mdc-image-list-...-columns to be consistent with below.
|
Ran into a lint error which IMO is due to unwise ordering in our stylelintrc, which I'm fixing in #2395 before merging this. |
Codecov Report
@@ Coverage Diff @@
## master #2381 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 100 100
Lines 4144 4144
Branches 535 535
=======================================
Hits 4098 4098
Misses 46 46Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2315