Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate train in class #206

Merged
merged 11 commits into from
Feb 29, 2024
Merged

Integrate train in class #206

merged 11 commits into from
Feb 29, 2024

Conversation

niekdejonge
Copy link
Collaborator

@niekdejonge niekdejonge commented Feb 27, 2024 •
edited
Loading

Small changes to improve clarity of embeddingsEvaluator

  • Added train_evaluator as method to EmbeddingEvaluatorModel
  • Added test for training EmbeddingEvaluator

@niekdejonge niekdejonge mentioned this pull request Feb 28, 2024
Merged
@florian-huber
Copy link
Contributor

Nice cleanup @niekdejonge . Thanks!

@florian-huber florian-huber merged commit 7c7b4e4 into dev_pytorch Feb 29, 2024
11 checks passed
@florian-huber florian-huber deleted the integrate_train_in_class branch February 29, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-huber florian-huber florian-huber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niekdejonge @florian-huber