Follow up: #94 Merge config from vendor

[ametad]

At my first attempt I forgot to begin with a new branch and got in trouble ;) Here is the second attempt.

Closes #84

[ametad]

Still have some problem with testing the config is there before- and after 'booting' the ServiceProvider. The config seems to be there all the time, already!

(#94 (comment))

I try some more.

[ametad]

I think this includes everything you want to :)

• Merge the config from the package
• Feature test, is the config available in the application
• Changelog
• Version bump

Is this ready to merge?

[matchish]

I think I know better way to test it.
Revert your changes in this test. We don't need new test method
Delete this file https://github.com/matchish/laravel-scout-elasticsearch/blob/master/tests/laravel/config/elasticsearch.php
After it a lot of tests should fail
Add your code $this->mergeConfigFrom(__DIR__.'/../config/elasticsearch.php it should fix them because of now we load config from vendor package
And move this code to the end of the test for cleanup
File::delete(config_path('elasticsearch.php'))

[matchish]

No, I was wrong we need two tests
test_config_publishing
Need to add to the end \File::delete(config_path('elasticsearch.php')); to clean up after test

test_config_is_merged_from_the_package
call register then boot
assert that config not false

And we should override this method in our test class

laravel-scout-elasticsearch/tests/TestCase.php

Line 33 in 623716c

protected function getEnvironmentSetUp($app)

And unset elasticsearch config

[ametad]

And unset elasticsearch config

The thing is, I think config keys cannot be unset at runtime. This is a problem, because a lot of testing needs the config set in \Tests\TestCase::getEnvironmentSetUp and therefore cannot be removed easily there.

Perhaps a local override of getEnvironmentSetUp that removes the elasticsearch config only for \Matchish\ScoutElasticSearch\ScoutElasticSearchServiceProviderTest. I will try that. This doesn't work for the same reason, config keys cannot be unset at runtime.

[ametad]

In cb02255 you see I moved the config needed for the Elastiscsearch integrations tests to it's base class.

Now the config is not loaded already in ScoutElasticSearchServiceProviderTest and we can test if the config is merged correctly from the package itself.

[matchish]

Great contribution! Thanks)