Need to add Routing meta-field to be able to use join datatype

ametad · Mar 14, 2020 · e07909b · e07909b
1 parent 6683500
commit e07909b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/ElasticSearch/Params/Bulk.php b/src/ElasticSearch/Params/Bulk.php
@@ -32,6 +32,8 @@ public function delete($docs): void
     }
 
     /**
+     * TODO: Add ability to extend payload without modifying the class
+     *
      * @return array
      */
     public function toArray(): array
@@ -47,6 +49,7 @@ function ($payload, $model) {
                         '_index' => $model->searchableAs(),
                         '_id' => $model->getScoutKey(),
                         '_type' => '_doc',
+                        'routing' => false === empty($model->routing) ? $model->routing : $model->getScoutKey(),
                     ],
                 ];
 
@@ -67,6 +70,7 @@ function ($payload, $model) {
                         '_index' => $model->searchableAs(),
                         '_id' => $model->getScoutKey(),
                         '_type' => '_doc',
+                        'routing' => false === empty($model->routing) ? $model->routing : $model->getScoutKey(),
                     ],
                 ];
 

diff --git a/tests/Unit/ElasticSearch/Params/BulkTest.php b/tests/Unit/ElasticSearch/Params/BulkTest.php
@@ -17,7 +17,7 @@ public function test_delete()
         $params = $bulk->toArray();
 
         $this->assertEquals([
-            'body' => [['delete' => ['_index' => 'products', '_type' => '_doc', '_id' => 2]]],
+            'body' => [['delete' => ['_index' => 'products', '_type' => '_doc', '_id' => 2, 'routing' => 2]]],
         ], $params);
     }
 
@@ -31,7 +31,7 @@ public function test_delete_with_custom_key_name()
         $params = $bulk->toArray();
 
         $this->assertEquals([
-            'body' => [['delete' => ['_index' => 'products', '_type' => '_doc', '_id' => 'Scout']]],
+            'body' => [['delete' => ['_index' => 'products', '_type' => '_doc', '_id' => 'Scout', 'routing' => 'Scout']]],
         ], $params);
     }
 
@@ -45,7 +45,7 @@ public function test_index()
 
         $this->assertEquals([
             'body' => [
-                ['index' => ['_index' => 'products', '_type' => '_doc', '_id' => 2]],
+                ['index' => ['_index' => 'products', '_type' => '_doc', '_id' => 2, 'routing' => 2]],
                 ['title' => 'Scout', 'id' => 2, '__class_name' => 'App\Product'],
             ],
         ], $params);
@@ -62,7 +62,7 @@ public function test_index_with_custom_key_name()
 
         $this->assertEquals([
             'body' => [
-                ['index' => ['_index' => 'products', '_type' => '_doc', '_id' => 'Scout']],
+                ['index' => ['_index' => 'products', '_type' => '_doc', '_id' => 'Scout', 'routing' => 'Scout']],
                 ['title' => 'Scout', 'id' => 2, '__class_name' => 'App\Product'],
             ],
         ], $params);
@@ -78,7 +78,7 @@ public function test_push_soft_delete_meta_data()
         $params = $bulk->toArray();
         $this->assertEquals([
             'body' => [
-                ['index' => ['_index' => 'products', '_type' => '_doc', '_id' => 2]],
+                ['index' => ['_index' => 'products', '_type' => '_doc', '_id' => 2, 'routing' => 2]],
                 ['title' => 'Scout', '__soft_deleted' => 0, 'id' => 2, '__class_name' => 'App\Product'],
             ],
         ], $params);