-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React/DP-13718: Fuzzy search default suggestions. #544
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
46c20b0
build suggestions
clairesunstudio 07102dc
tie suggestions to focuz
clairesunstudio 013c982
styling overflow
clairesunstudio b8a244b
styling overflow
clairesunstudio 67e4b06
add onBlur
clairesunstudio a80a4bc
persist event to get keydown target
clairesunstudio 8617676
install console addon to storybook
clairesunstudio 85779b9
fix keyboard accessibility on default options
clairesunstudio 6e0d328
reset highlight index on blur
clairesunstudio aea649c
add renderDefaultSuggestion prop to inputTextFuzzy
clairesunstudio 0182463
remove inputTextTypeAhead
clairesunstudio 0e2ab8c
add changelog
clairesunstudio cc1a3d4
add changelog
clairesunstudio 3740f25
Revert "remove inputTextTypeAhead"
clairesunstudio d08f450
add deprecation note
clairesunstudio 746a882
check for env variable for warning
clairesunstudio 14ee171
show default suggestions on clear
clairesunstudio 3a84290
pass value to onchange callback
clairesunstudio 104084b
Updates InputTextFuzzy component logic using setState, fixes onChange…
smurrayatwork d9a2870
Fixes merge conflict.
smurrayatwork 3b7dedf
Bug Fixes.
smurrayatwork 9b87a97
update is and add onChange
clairesunstudio aaa4670
remove search on empty query
clairesunstudio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Minor | ||
Added | ||
- (React) [InputTextFuzzy] DP-13688: Added option to render all options as suggestions by default, via prop `renderDefaultSuggestion` #544 | ||
- (React) [Storybook Config] DP-13688: Added storybook console addon #544 | ||
|
||
Removed | ||
- (React) [InputTextTypeAhead] DP-13688: Deprecate InputTextTypeAhead. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 5 additions & 1 deletion
6
react/src/components/atoms/forms/InputTextTypeAhead/InputTextTypeAhead.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
#### Description | ||
A typeahead input text field. This atom is only available in Mayflower-React. | ||
|
||
This component is deprecated and is replaced by [InputTextFuzzy](../InputTextFuzzy). | ||
|
||
This component will be archive in the next major version. | ||
|
||
#### Dependencies | ||
This atom is dependent on the module [react-autosuggest](https://github.com/moroshko/react-autosuggest) and parse from the module [autosuggest-highlight](https://github.com/moroshko/autosuggest-highlight) | ||
This atom is dependent on the module [react-autosuggest](https://github.com/moroshko/react-autosuggest) and parse from the module [autosuggest-highlight](https://github.com/moroshko/autosuggest-highlight) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think we should pass this callback in blur
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onSuggestionClick is when you select on a suggestion, e.g. we use it to navigate to a url and that shouldn't be triggered onBlur