React/DP-13718: Fuzzy search default suggestions. #544
Conversation
clairesunstudio
changed the title
clairesunstudio
requested review from
smurrayatwork and
avrilpearl
and removed request for
smurrayatwork
clairesunstudio
added
external review
internal review
and removed
WIP - Do not merge
labels
… to actually pass useful information.
smurrayatwork
changed the title
| }); | ||
| } else { |
There was a problem hiding this comment.
is this change on purpose? moving the callback into setState in the if block will only callback if value is empty?
There was a problem hiding this comment.
since we are not using state in props.onChange function, what's the difference putting it in callback vs outside of setState? if we pass it as callback we will have to do it in the setState below also
| highlightedItemIndex: null | ||
| }, () => { | ||
| if (is.fn(this.props.onSuggestionClick)) { | ||
| this.props.onSuggestionClick(event, { |
There was a problem hiding this comment.
i don't think we should pass this callback in blur
There was a problem hiding this comment.
onSuggestionClick is when you select on a suggestion, e.g. we use it to navigate to a url and that shouldn't be triggered onBlur
| onKeyDown: (event, { newHighlightedSectionIndex, newHighlightedItemIndex }) => { | ||
| onFocus: this.handleFocus, | ||
| onBlur: (event) => { | ||
| event.persist(); |
There was a problem hiding this comment.
don't think we need to persist this event unless we want to pass a custom callback
Minor
Added
renderDefaultSuggestionRemoved
To test:
yarn link-mayflower in budget: https://github.com/massgov/budget/pull/242