Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning operation size. #3354

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Fix warning operation size. #3354

merged 1 commit into from
Dec 29, 2022

Conversation

AurelienFT
Copy link
Contributor

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Fix #2597

@aoudiamoncef aoudiamoncef merged commit 30b129f into testnet_18 Dec 29, 2022
This was referenced Dec 29, 2022
Closed
Merged
bors bot added a commit that referenced this pull request Jan 2, 2023
@bors @AurelienFT @Eitu33
Merge #3280
a0ecab8 
3280: Testnet 18 r=AurelienFT a=AurelienFT

PR for testnet 18. PRS in this testnet : 

- #3303 
- #3301 
- #3279 
- #3318 
- #3315
- #3332
- #3228 
- #3323 
- #3312 
- #3333 
- #3336 
- #3340 
- #3206 
- #3320 
- #3314 
- #3342 
- #3343 
- #3346
- #3339 
- #3351 
- #3349 
- #3354 
- #3348 
- #3347 

Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
Co-authored-by: AurelienFT <32803821+AurelienFT@users.noreply.github.com>
Co-authored-by: Thomas Plisson <thomas.plisson@epitech.eu>
Co-authored-by: Eitu33 <89928840+Eitu33@users.noreply.github.com>
@AurelienFT AurelienFT deleted the fix_waning_client branch May 29, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qdrn qdrn Awaiting requested review from qdrn

@aoudiamoncef aoudiamoncef Awaiting requested review from aoudiamoncef

@Eitu33 Eitu33 Awaiting requested review from Eitu33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelienFT @aoudiamoncef