Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytecode size exceeded half of the maximum size of a block, operation will certainly be rejected #2597

Closed
qdrn opened this issue May 6, 2022 · 1 comment
Closed

bytecode size exceeded half of the maximum size of a block, operation will certainly be rejected #2597

qdrn opened this issue May 6, 2022 · 1 comment
Assignees
@AurelienFT

Comments

@qdrn
Copy link
Contributor

qdrn commented May 6, 2022

This warning is confusing as it happens both when you exceed the half of the maximum (no problem, just expensive), and when you exceed the size of a block (can never be included).

I think we should either revert to data.len() > max_block_size as usize or have two different warnings.
@AurelienFT AurelienFT self-assigned this Dec 29, 2022
@AurelienFT AurelienFT mentioned this issue Dec 29, 2022
Merged
7 tasks
@AurelienFT
Copy link
Contributor

Fix in #3354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurelienFT AurelienFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qdrn @AurelienFT