Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saveOnEnter : Use normal click on Save button and fix helperText linked issue #4410

Merged
merged 10 commits into from
Feb 12, 2020
Merged

Fix saveOnEnter : Use normal click on Save button and fix helperText linked issue #4410

merged 10 commits into from
Feb 12, 2020

Conversation

JulienMattiussi
Copy link
Contributor

@JulienMattiussi JulienMattiussi commented Feb 11, 2020 •
edited
Loading

Closes #4170

  • Use normal click on Save button
  • Fix helperText place issue on ReferenceInput
  • Fix helperText place issue on RichTextInput
  • Fix tests

Fixes and behaviour

  • The Create or Edit Forms can now be validated with a click or with the Enter key
  • The helperText place is reserved for all inputs to ensure the Save button won't move down if a requirement text fires at validation.
  • It's possible to disable this default helperText by adding helperText={false} on inputs
  • The ReferenceInputs in Filters won't have a bad margin anymore.
  • ReferenceInput doesn't accept an helperText value, it should be set on the child component

Screenshots

SubmitOnEnter

image

@JulienMattiussi JulienMattiussi added the WIP Work In Progress label Feb 11, 2020
@JulienMattiussi JulienMattiussi changed the title Fix SaveOnEnter, use normal click on Save button and fix helper texts linked issues Fix SaveOnEnter, use normal click on Save button and fix helper text linked issue Feb 11, 2020
@JulienMattiussi JulienMattiussi changed the title Fix SaveOnEnter, use normal click on Save button and fix helper text linked issue Fix saveOnEnter : Use normal click on Save button and fix helperText linked issue Feb 11, 2020
@JulienMattiussi JulienMattiussi added RFR Ready For Review and removed WIP Work In Progress labels Feb 11, 2020
Luwangel
Luwangel suggested changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@Luwangel Luwangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write tests to ensure it's fixed?

fzaninotto
fzaninotto requested changes Feb 12, 2020
View reviewed changes
cypress/integration/create.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/button/SaveButton.spec.tsx Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit 196cb43 into master Feb 12, 2020
@fzaninotto fzaninotto deleted the fix-save-on-enter branch February 12, 2020 15:41
@fzaninotto fzaninotto added this to the 3.2.2 milestone Feb 12, 2020
This was referenced Apr 10, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luwangel Luwangel Luwangel requested changes

@djhi djhi djhi requested changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.

Unable to submit a form using the keyboard
5 participants
@JulienMattiussi @fzaninotto @christiaanwesterbeek @djhi @Luwangel