Allow to disable helperText place on inputs

marmelab · Feb 11, 2020 · 460e971 · 460e971
1 parent e217c8e
commit 460e971
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 15 deletions.
diff --git a/packages/ra-ui-materialui/src/input/AutocompleteInput.tsx b/packages/ra-ui-materialui/src/input/AutocompleteInput.tsx
@@ -102,6 +102,7 @@ const AutocompleteInput: FunctionComponent<
     format,
     fullWidth,
     helperText,
+    disableHelperText,
     id: idOverride,
     input: inputOverride,
     isRequired: isRequiredOverride,
@@ -390,11 +391,13 @@ const AutocompleteInput: FunctionComponent<
                                 htmlFor: id,
                             })}
                             helperText={
-                                <InputHelperText
-                                    touched={touched}
-                                    error={error}
-                                    helperText={helperText}
-                                />
+                                disableHelperText ? null : (
+                                    <InputHelperText
+                                        touched={touched}
+                                        error={error}
+                                        helperText={helperText}
+                                    />
+                                )
                             }
                             variant={variant}
                             margin={margin}

diff --git a/packages/ra-ui-materialui/src/input/SearchInput.tsx b/packages/ra-ui-materialui/src/input/SearchInput.tsx
@@ -27,6 +27,7 @@ const SearchInput: FunctionComponent<
             hiddenLabel
             label=""
             resettable
+            disableHelperText={true}
             placeholder={translate('ra.action.search')}
             InputProps={{
                 endAdornment: (

diff --git a/packages/ra-ui-materialui/src/input/SelectInput.tsx b/packages/ra-ui-materialui/src/input/SelectInput.tsx
@@ -154,6 +154,7 @@ const SelectInput: FunctionComponent<
     emptyValue,
     format,
     helperText,
+    disableHelperText,
     label,
     onBlur,
     onChange,
@@ -223,11 +224,13 @@ const SelectInput: FunctionComponent<
             clearAlwaysVisible
             error={!!(touched && error)}
             helperText={
-                <InputHelperText
-                    touched={touched}
-                    error={error}
-                    helperText={helperText}
-                />
+                disableHelperText ? null : (
+                    <InputHelperText
+                        touched={touched}
+                        error={error}
+                        helperText={helperText}
+                    />
+                )
             }
             {...options}
             {...sanitizeRestProps(rest)}
@@ -274,6 +277,7 @@ SelectInput.propTypes = {
     resource: PropTypes.string,
     source: PropTypes.string,
     translateChoice: PropTypes.bool,
+    disableHelperText: PropTypes.bool,
 };
 
 SelectInput.defaultProps = {
@@ -285,6 +289,7 @@ SelectInput.defaultProps = {
     optionValue: 'id',
     translateChoice: true,
     disableValue: 'disabled',
+    disableHelperText: false,
 };
 
 export default SelectInput;
diff --git a/packages/ra-ui-materialui/src/input/TextInput.tsx b/packages/ra-ui-materialui/src/input/TextInput.tsx
@@ -28,6 +28,7 @@ const TextInput: FunctionComponent<TextInputProps> = ({
     label,
     format,
     helperText,
+    disableHelperText,
     onBlur,
     onFocus,
     onChange,
@@ -73,11 +74,13 @@ const TextInput: FunctionComponent<TextInputProps> = ({
             }
             error={!!(touched && error)}
             helperText={
-                <InputHelperText
-                    touched={touched}
-                    error={error}
-                    helperText={helperText}
-                />
+                disableHelperText ? null : (
+                    <InputHelperText
+                        touched={touched}
+                        error={error}
+                        helperText={helperText}
+                    />
+                )
             }
             {...options}
             {...sanitizeRestProps(rest)}
@@ -91,10 +94,12 @@ TextInput.propTypes = {
     options: PropTypes.object,
     resource: PropTypes.string,
     source: PropTypes.string,
+    disableHelperText: PropTypes.bool,
 };
 
 TextInput.defaultProps = {
     options: {},
+    disableHelperText: false,
 };
 
 export default TextInput;