[RFR] Warn About Outdated Material-UI version #2228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
reviewed
Aug 28, 2018
| @@ -53,6 +53,7 @@ | |||
| "react-transition-group": "^2.2.1", | |||
| "recompose": "~0.26.0", | |||
| "redux": "~3.7.2", | |||
| "redux-form": "~7.4.0" | |||
| "redux-form": "~7.4.0", | |||
| "warning": "^4.0.2" | |||
There was a problem hiding this comment.
We didn't use the warning package for all other warnings. I think we should either drop it or use it everywhere
There was a problem hiding this comment.
It is used on ra-core.
Kmaschta
force-pushed
the
warn-for-outdated-mui
branch
from
bf2c459 to
aa25b66
Compare
|
Review applied |
|
In fact, I think it's the responsibility of material-ui to do that. React warns developers if there are more than one version loaded, material-ui should do the same. |
2 tasks
|
Nvm, I opened an issue on MUI about this. mui/material-ui#12781 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a small idea that I found to warn developers about the outdated Material-UI issue on production (#1782).
It can be added in addition to #2215. I've considered other alternatives like throwing an error at the build phase or read the
@material-ui/core/package.jsonbut it's the less intrusive method I found.Here is the result on the console: