Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section about production build ui bug in docs #2215

Merged
merged 2 commits into from
Sep 19, 2018

Conversation

edouardmenayde
Copy link
Contributor

I struggled for hours with this and by chance found the issue talking about it but the next person might not have the same luck I did thus I think documenting the possible bug is important.

@edouardmenayde edouardmenayde changed the title Add a section about production build ui bug Add a section about production build ui bug in docs Aug 26, 2018
@fzaninotto
Copy link
Member

We're using @material-ui/core@^1.4.0, which means that any version older than 1.4.0 will work. Which version were you using?

docs/FAQ.md Outdated
## UI in production build is empty or broke

Your `@material-ui/core` and `@material-ui/icons` version specified in `package.json` should be the same version used by `react-admin`.
See this [issue for more information](https://github.com/marmelab/react-admin/issues/1782).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than linking to the issue, it would probably be better to add the instructions directly here

@edouardmenayde
Copy link
Contributor Author

edouardmenayde commented Aug 27, 2018

@fzaninotto I was using an older version of react-admin and an older version of material ui core. I don't understand what was happening but nontheless I think it's important for it to appear in the docs.
@djhi I'm not sure because the issue will update itself easier than the docs. + The instruction in the wiki are general and good enough for anyone to fix its problem.

docs/FAQ.md Show resolved Hide resolved
docs/FAQ.md Outdated

## UI in production build is empty or broke

Your `@material-ui/core` and `@material-ui/icons` version specified in `package.json` should be the same version used by `react-admin`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably rephrase this sentence as follows:

You have probably specified a version requirement for @material-ui/core that is incompatible with the one required by react-admin. As a consequence, npm bundled two copies of material-ui in your application, and material-ui doesn't work in that case.

Please align your version requirement with the one of the ra-ui-materialui package.

@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 2.3.2 milestone Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants