Update React (and react-dom) to 15.4.0 and react-tap-event-plugin to 2.0.1 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petetnt
changed the title
|
Argh, now the CI failed. Lemme see that one more time 😢 |
djhi
approved these changes
Nov 18, 2016
|
I'll test locally and merge by hand if successful. |
|
I found a version conflict in material UI:
So we can't merge this PR until mui/material-ui#5590 is solved. |
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin Update React too for correct peer deps Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
fzaninotto
force-pushed
the
petetnt-update-deps
branch
from
9946b6f
to
e9c5083
Compare
|
Thanks @fzaninotto 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to fix React 15.4.0 compatibility).
This PR builds on the previous PR #153 which was reverted in #154 due to NPM warnings about missing peer deps (which I missed because my peer deps matched the ones that prompted the update in the first place).
All tests pass, example works as it worked with the previous version.
Sorry about the hassle. cc @fzaninotto
--- Old message:
react-v15.4.0 broke
react-tap-event-plugin@v1, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths toreact-dom.Signed-off-by: petetnt pete.a.nykanen@gmail.com