Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-tap-event-plugin to 2.0.1 #153

Merged
merged 1 commit into from
Nov 17, 2016

Conversation

petetnt
Copy link
Contributor

@petetnt petetnt commented Nov 17, 2016

... to fix React 15.4.0 compatibility).

react-v15.4.0 broke react-tap-event-plugin@v1, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to react-dom.

https://www.npmjs.com/package/react-tap-event-plugin

... to fix React 15.4.0 compatibility). 

[react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`.

https://www.npmjs.com/package/react-tap-event-plugin
@jpetitcolas jpetitcolas merged commit cfbf57e into marmelab:master Nov 17, 2016
@jpetitcolas
Copy link
Contributor

Thanks! :)

@fzaninotto
Copy link
Member

I have to revert this one, it makes the install fail. See #154.

Feel free to open a new PR with an updated package.json that does NOT throw warnings.

@petetnt
Copy link
Contributor Author

petetnt commented Nov 18, 2016

Oh dang, sorry about that. I'll fix those and send a new PR asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants