Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SimpleList rowClick #10385

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Introduce SimpleList rowClick #10385

merged 6 commits into from
Dec 4, 2024

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Nov 27, 2024

Problem

Supersedes #10349

The linkType for SimpleList provides less functionality than the rowClick for DataGrid. And also the inconsistency makes it harder to use.

Solution

Implement rowClick prop as it works for Datagrid.
Keep the linkType prop working as previously, but show it as deprecated. If both are set, linkType takes precedence (because it will be simpler to remove from the code later that way).

It also fixes an issue introduced by #10343 that produced nested li which is invalid HTML.

How To Test

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

@slax57 slax57 self-requested a review December 4, 2024 09:04
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question: shouldn't you create the same story as IconsAvatarsAndLinkType but with RowClick?

@slax57 slax57 added this to the 5.5.0 milestone Dec 4, 2024
@slax57 slax57 merged commit aaba7ef into next Dec 4, 2024
15 checks passed
@slax57 slax57 deleted the simple-list-rowclick branch December 4, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants