-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SimpleList rowClick #10385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
djhi
commented
Nov 27, 2024
djhi
commented
Nov 27, 2024
slax57
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more question: shouldn't you create the same story as IconsAvatarsAndLinkType
but with RowClick
?
packages/ra-ui-materialui/src/list/SimpleList/SimpleList.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/SimpleList/SimpleList.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/SimpleList/SimpleList.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/SimpleList/SimpleListItem.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/SimpleList/SimpleList.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/SimpleList/SimpleList.spec.tsx
Outdated
Show resolved
Hide resolved
slax57
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Supersedes #10349
Solution
It also fixes an issue introduced by #10343 that produced nested
li
which is invalid HTML.How To Test
linkType
: https://react-admin-storybook-2x9vrs84o-marmelab.vercel.app/?path=%2Fstory%2Fra-ui-materialui-list-simplelist--link-typerowClick
: https://react-admin-storybook-2x9vrs84o-marmelab.vercel.app/?path=%2Fstory%2Fra-ui-materialui-list-simplelist--row-clickli
. Besides, this error should not appear anymore in the tests output.Additional Checks
master
for a bugfix, ornext
for a feature