Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <SimpleList linkType={false}> UI #10343

Merged
merged 9 commits into from
Nov 14, 2024
Merged

Fix <SimpleList linkType={false}> UI #10343

merged 9 commits into from
Nov 14, 2024

Conversation

erwanMarmelab
Copy link
Contributor

Problem

linkType should only remove the onClick action but it breaks the UI.

Without linkType

image

With linkType={false}

image

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes one or several stories (if not possible, describe why)

@erwanMarmelab erwanMarmelab added the RFR Ready For Review label Nov 12, 2024
@erwanMarmelab erwanMarmelab added WIP Work In Progress and removed RFR Ready For Review labels Nov 12, 2024
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Nov 13, 2024
@erwanMarmelab erwanMarmelab added WIP Work In Progress and removed RFR Ready For Review labels Nov 13, 2024
@erwanMarmelab
Merge branch 'fix/SimpleList_UI_on_linkType_is_false' of github.com:m…
3b95137 
…armelab/react-admin into fix/SimpleList_UI_on_linkType_is_false
@erwanMarmelab erwanMarmelab added RFR Ready For Review and removed WIP Work In Progress labels Nov 14, 2024
@djhi djhi merged commit d203612 into master Nov 14, 2024
15 checks passed
@djhi djhi deleted the fix/SimpleList_UI_on_linkType_is_false branch November 14, 2024 16:16
@djhi djhi added this to the 5.3.4 milestone Nov 14, 2024
@djhi djhi mentioned this pull request Nov 27, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto requested changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@erwanMarmelab @fzaninotto @djhi