Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Essential and containerMemory as params #85

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

samkahchiin
Copy link

Summary

  • Add Essential and containerMemory as params

@samkahchiin samkahchiin force-pushed the samkahchiin/add-essential-and-container-memory branch 2 times, most recently from ef21418 to bb4a509 Compare October 20, 2022 07:30
@@ -0,0 +1 @@
* @dbl-works/dev-ops-admin
Copy link
Contributor

@swiknaba swiknaba Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to backport PR's from a branch that has this file removed, see: #84

--> Maybe we open a branch on our fork specific for that, and name it e.g. backport?

... or we drop this file entirely, and manage access to this repo manually instead of via teams

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped this on our fork and replaced functionality by manually adding people in the settings to ease upstreaming.

@marcqualie
Copy link
Owner

@samkahchiin What is containerMemory in this context? There is already a memory field, which containerMemory seems to just update here but without the predefined values.

@samkahchiin
Copy link
Author

@marcqualie
the containerMemory refer to the memory attribute under the container definitions => https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#container_definition_memory
This will allow user to decide the memory allocated to the specified container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants