Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add siblingContainers and dependsOn options to the task definitions #84

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

swiknaba
Copy link
Contributor

Usage example where a 2nd process is launched within each task that runs Rails; in this example, the open telemetry collector for AWS XRay.

Patched that in as alpha-1 to the 0.8.x release, let me know if any other version should be used for that.

# ecsx.yml

tasks:
  $rails: &rails
    <<: *default
    envVars:
      PORT: "3000"
      RAILS_MAX_THREADS: "4"
    secrets:
      - name: app
        keys:
          - RAILS_MASTER_KEY
          - DATABASE_URL_MASTER
  aws_otel_collector:
    image: "amazon/aws-otel-collector:v0.20.0"
    command:
      - --config=/etc/ecs/ecs-default-config.yaml


  web:
    <<: *rails
    command:
      - bundle
      - exec
      - puma
    siblingContainers:
      - aws_otel_collector
    dependsOn:
      - containerName: "aws_otel_collector"
        condition: "START"

@marcqualie
Copy link
Owner

@swiknaba @samkahchiin Thanks for the contribution! 🎉

@marcqualie marcqualie merged commit 0477204 into marcqualie:main Oct 21, 2022
@marcqualie marcqualie deleted the 0.8.0-alpha.1 branch October 21, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants