-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node CHANGELOG.md #928
Conversation
Not sure this is really a feature. It's more of a bugfix actually. We were otherwise C++17 for a while now (maybe that should actually be the feature). |
Ah yes, it's not a feature, I'm just following the former notes, since a PR was approved and I forgot to mention it in the CHANGELOG.md. |
Our main focus is Core, Android and iOS and in principle we don't spend too much time on other platforms. We also don't make releases for them. |
What I meant is we may want to define general guidelines on changelogs and release notes. |
Thanks for clarifying this @louwers. People are welcome to contribute to all platforms and it is great if they handle releases. The paid maintainers focus is on iOS and Android. |
Maybe I should have tagged you Oliver then 😊 |
Usually I do the node releases, so I appreciate the changelog being updated since it helps me make the release notes. I agree though that this should be under bug fixes. maybe something like "Fix std=c++11 warnings when building windows node release", or something like that. Could you add a heading
and add this under it, like https://github.com/maplibre/maplibre-gl-native/blob/main/CHANGELOG.md |
If you could also add an entry for #904 , that would be nice too :-) . I think that one would be new feature. |
Done! |
No description provided.