Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node CHANGELOG.md #928

Merged
merged 4 commits into from
Mar 25, 2023
Merged

Update Node CHANGELOG.md #928

merged 4 commits into from
Mar 25, 2023

Conversation

tdcosta100
Copy link
Collaborator

No description provided.

@ntadej
Copy link
Collaborator

ntadej commented Mar 22, 2023

Not sure this is really a feature. It's more of a bugfix actually. We were otherwise C++17 for a while now (maybe that should actually be the feature).

@tdcosta100
Copy link
Collaborator Author

Ah yes, it's not a feature, I'm just following the former notes, since a PR was approved and I forgot to mention it in the CHANGELOG.md.

@ntadej
Copy link
Collaborator

ntadej commented Mar 22, 2023

OK, maybe something for @louwers and @ovivoda to try to improve in the future.

@louwers
Copy link
Collaborator

louwers commented Mar 22, 2023

Our main focus is Core, Android and iOS and in principle we don't spend too much time on other platforms. We also don't make releases for them.

@tdcosta100 tdcosta100 changed the title Update CHANGELOG.md Update Node CHANGELOG.md Mar 23, 2023
@ntadej
Copy link
Collaborator

ntadej commented Mar 23, 2023

What I meant is we may want to define general guidelines on changelogs and release notes.

@wipfli
Copy link
Contributor

wipfli commented Mar 23, 2023

Thanks for clarifying this @louwers. People are welcome to contribute to all platforms and it is great if they handle releases. The paid maintainers focus is on iOS and Android.

@ntadej
Copy link
Collaborator

ntadej commented Mar 23, 2023

Maybe I should have tagged you Oliver then 😊

@acalcutt
Copy link
Collaborator

acalcutt commented Mar 23, 2023

Usually I do the node releases, so I appreciate the changelog being updated since it helps me make the release notes.

I agree though that this should be under bug fixes. maybe something like "Fix std=c++11 warnings when building windows node release", or something like that.

Could you add a heading

### 🐞 Bug fixes
*...Add new stuff here...*

and add this under it, like https://github.com/maplibre/maplibre-gl-native/blob/main/CHANGELOG.md

@acalcutt
Copy link
Collaborator

If you could also add an entry for #904 , that would be nice too :-) . I think that one would be new feature.

@tdcosta100
Copy link
Collaborator Author

Done!

@acalcutt acalcutt merged commit 7c96e51 into maplibre:main Mar 25, 2023
@tdcosta100 tdcosta100 deleted the patch-1 branch March 25, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants