-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Node Map object options "request" property optional #904
Conversation
dcd9dde
to
7707b80
Compare
What's the difference between the internal loaders and the one you implement yourself? Would it work with http and local files or would it depend what you wanted to use this with if you need to implement your own. What do these default options work with? Based on the documentation at https://github.com/maplibre/maplibre-gl-native/tree/main/platform/node , the implementation of options is different if you are doing local file vs https request. |
The internal loaders implement their own logic, you can learn about them here. But they work well for the basics. There is a provider for local files ( |
An addendum: if you implement your request function, then the internal loaders are disabled and all requests are sent to your function, exactly like it was before this PR. |
7707b80
to
3319c0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript index.d.ts
needs to be updated to reflect this.
Done! |
d1a6fc1
to
a422920
Compare
a422920
to
5729ec9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it seems to work. I was able to use options like was required in the past, or go without the options all together.
Can you add an entry to the node readme for this.
5729ec9
to
073d741
Compare
Nice. Please check if the |
The current Node Map requires you to implement a
request
function, so everything Node Map needs, it asks to this function. This PR allows you to choose if you really want this, or if it's ok to let Node Map use its internal loaders.