-
-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: #270 update dependencies #276
Conversation
Bundle size report: Size Change: -15 B
ℹ️ View DetailsNo major changes |
@chippieTV any updates on this? I'd be great if this will be a part of the typescript branch before we merge it to main. |
…ach and afterEach
2173667
to
7c3c900
Compare
lots of tests are still failing, it's not even clear which scripts in package.json I should expect to run, I guess mainly just the ones the CI is looking at. I'm not even 100% sure my environment runs the tests properly on the typescript branch at the moment, might need to clean up my local a bit I might be better off with a more targeted set of updates, maybe this weekend I can get a small subset of working updates and we can do bit by bit.. |
PR for safer version of this updating.. #295 I can still access this one if it gets closed so maybe that's fine. I have locally so can always refer to any fixes for updates. I'll leave it for now so anyone who feels like it can see what kinds of errors we get if we update with too much optimism |
First pass at updating, build and many tests passing, fixing/reverting bad libraries as necessary. This may not be the best way to go about this but there are so many libraries to update that I think update most of them and firefight backwards is a reasonable plan. In theory it should be possible to identify the problem libraries and make a list of "OK to update" ones.
Typescript 4.4.2 removes type for OffscreenBuffer, add @types/offscreenbuffer to fix
tap 15 deprecates callbacks in beforeEach and afterEach, remove callbacks (affected tests passing again)
D3 v5 deprecates queue used in test harness. It is possible to replace with regular promises and no library, or possibly p-queue may be an option: to investigate (for now rolled D3 back to v4)
npm run test-unit
16601 passing 16 failingnpm run test-expressions
100% passingnpm run test-render
fails (but also fails in main typescript branch, however was not included in CI.. fails on main too AFAIK)npm run test-build
fails 1 test: to investigate