Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: #270 update dependencies #276

Closed
wants to merge 8 commits into from

Conversation

chippieTV
Copy link
Contributor

@chippieTV chippieTV commented Aug 29, 2021

  • confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • briefly describe the changes in this PR

First pass at updating, build and many tests passing, fixing/reverting bad libraries as necessary. This may not be the best way to go about this but there are so many libraries to update that I think update most of them and firefight backwards is a reasonable plan. In theory it should be possible to identify the problem libraries and make a list of "OK to update" ones.

  • Typescript 4.4.2 removes type for OffscreenBuffer, add @types/offscreenbuffer to fix

  • tap 15 deprecates callbacks in beforeEach and afterEach, remove callbacks (affected tests passing again)

  • D3 v5 deprecates queue used in test harness. It is possible to replace with regular promises and no library, or possibly p-queue may be an option: to investigate (for now rolled D3 back to v4)

  • npm run test-unit 16601 passing 16 failing

  • npm run test-expressions 100% passing

  • npm run test-render fails (but also fails in main typescript branch, however was not included in CI.. fails on main too AFAIK)

  • npm run test-build fails 1 test: to investigate

@github-actions
Copy link
Contributor

Bundle size report:

Size Change: -15 B
Total Size Before: 198 kB
Total Size After: 197 kB

Output file Before After Change
maplibre-gl.js 188 kB 188 kB 0 B
maplibre-gl.css 9.55 kB 9.53 kB -15 B
ℹ️ View Details No major changes

@HarelM
Copy link
Collaborator

HarelM commented Sep 1, 2021

@chippieTV any updates on this? I'd be great if this will be a part of the typescript branch before we merge it to main.
@astridx didn't you want to tackle this too?

@chippieTV
Copy link
Contributor Author

lots of tests are still failing, it's not even clear which scripts in package.json I should expect to run, I guess mainly just the ones the CI is looking at. I'm not even 100% sure my environment runs the tests properly on the typescript branch at the moment, might need to clean up my local a bit

I might be better off with a more targeted set of updates, maybe this weekend I can get a small subset of working updates and we can do bit by bit..

@chippieTV
Copy link
Contributor Author

PR for safer version of this updating.. #295

I can still access this one if it gets closed so maybe that's fine. I have locally so can always refer to any fixes for updates. I'll leave it for now so anyone who feels like it can see what kinds of errors we get if we update with too much optimism

@HarelM HarelM deleted the branch maplibre:typescript September 3, 2021 05:29
@HarelM HarelM closed this Sep 3, 2021
@chippieTV chippieTV mentioned this pull request Sep 4, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants