270 update dependencies #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update testem to 3.5.0 update eslint update selenium (from beta.4 to rc-1) update rollup, plugin-strip and remove deprecated rolllup @types update react, react-dom and types update @babel/core to 7.15.0 update stylelint 9.10.1 -> 13.13.1, types and config patch update to @types/jsonwebtoken patch update to @types/request update tape to 5.3.1 update sinon to 11.1.2 and types update semver to 7.3.5 update chalk to 4.1.2 update browserify to 17.0.0 update cssnano to 5.0.8 update pngjs to 6.0.0 and types update patch @babel/core 7.15.4 update puppeteer to 10.2.0 update json-stringify-pretty-compact to 3.0.0 update ejs to 3.1.6 and types update st to 3.0.0
chippieTV
force-pushed
the
main-270-update-deps
branch
from
f526a28 to
2cb1af7
Compare
|
Bundle size report: Size Change: -3.33 kB
ℹ️ View Details
|
|
Cool. |
HarelM
approved these changes
Sep 4, 2021
|
It's working but as you can see.. not 100% complete. The remaining libraries require more effort to fix. I think it's good for now and we can open issues for these others later depending if other changes leave some of these packages no longer necessary summary of issues (for other PRs) d3 5.0+ causes issues - deprecates queue used in test harness. It is possible to replace with regular promises and no library, or possibly p-queue may be an option: to investigate (for now will not update) jsdom 17.0.0 causes issues so I rolled back until I have time to investigate and/or step through releases tap 15 deprecates callbacks in beforeEach and afterEach, remove callbacks (affected tests passing again in other PR, will transfer the changes and update soon) documentation 13+ breaks testem (npm run start-tests), not sure exactly which version or why yet diff 5.0.0 breaks test-query |
|
Nice work! I agree the rest can be done separately. |
|
when I tried updating Tap to 15, even after fixing the main issue of the deprecated before/after, there are only a couple of errors, 9 of the unit tests fail, so nothing significant. If we are switching to something else (or investigating how much effort that is) I agree it's not really worth to spend too much time on these, but if there's a quick win it might ease the transition. The later versions of Tap do support Typescript, so it might be worth looking into pros/cons of the options before committing to anything major. I'm also curious about using AVA, but I think any of these might require significant rewrites of the tests themselves, which would be quite a rabbit hole. Running against the .ts files should mean for Tap at least we don't need to run the build first. It's not very heavy to build so not a huge time saver, but probably a little cleaner to work with.. |
|
I agree. You see it the way I do. Converting the tests to typescript and referencing the ts files would be ideal, but not super urgent. |
|
yes please! |
|
I propose we enable dependabot with the following # To get started with Dependabot version updates, you'll need to specify which
# package ecosystems to update and where the package manifests are located.
# Please see the documentation for all configuration options:
# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
version: 2
updates:
- package-ecosystem: "npm" # See documentation for possible values
directory: "/" # Location of package manifests
schedule:
interval: "daily"
ignore:
- dependency-name: "@types/d3"
- dependency-name: "@types/diff"
- dependency-name: "d3"
- dependency-name: "diff"
- dependency-name: "documentation"
- dependency-name: "jsdom"
- dependency-name: "tap"Any objections or other input? |
|
Go ahead. |
wipfli
referenced
this pull request
in wipfli/maplibre-gl-js
Sep 9, 2021
Resolves #270 * update typescript to 4.4.2 update testem to 3.5.0 update eslint update selenium (from beta.4 to rc-1) update rollup, plugin-strip and remove deprecated rolllup @types update react, react-dom and types update @babel/core to 7.15.0 update stylelint 9.10.1 -> 13.13.1, types and config patch update to @types/jsonwebtoken patch update to @types/request update tape to 5.3.1 update sinon to 11.1.2 and types update semver to 7.3.5 update chalk to 4.1.2 update browserify to 17.0.0 update cssnano to 5.0.8 update pngjs to 6.0.0 and types update patch @babel/core 7.15.4 update puppeteer to 10.2.0 update json-stringify-pretty-compact to 3.0.0 update ejs to 3.1.6 and types update st to 3.0.0 * update nyc to 15.1.0 * update @octokit/rest to 18.10.0 * update node-notifier to 10.0.0 * update npm-packlist to 3.0.0 * update @mapbox/mapbox-gl-supported to 2.0.0 * update @mapbox/gazetteer to 5.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were separate commits however rebasing ontop of main from typescript causes too many conflicts, so I squashed before cherry-picking to get this branch updated.
Original PR #295
before
after (below not updated yet)