This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Integrate Telemetry SDK as framework dependency #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrex
force-pushed
the
jrex-telemetry-integration
branch
from
6657024 to
fd20c8e
Compare
|
This PR bumps the no-content timeout to 20mins (up from 5 minutes) - we need to investigate this as tail work. |
|
julianrex
force-pushed
the
jrex-telemetry-integration
branch
from
20d2180 to
66daa95
Compare
julianrex
requested review from
a team
and removed request for
1ec5 and
a team
julianrex
requested review from
fabian-guerra
and removed request for
jmkiley
nishant-karajgikar
approved these changes
Nov 25, 2019
fabian-guerra
approved these changes
Nov 25, 2019
| @@ -87,7 +87,7 @@ | |||
| </MacroExpansion> | |||
| </LaunchAction> | |||
| <ProfileAction | |||
| buildConfiguration = "Release" | |||
| buildConfiguration = "RelWithDebInfo" | |||
There was a problem hiding this comment.
Why is this changing?
There was a problem hiding this comment.
This is a hold-over from previous testing - however, it's easier to get meaningful results when profiling with symbols.
platform/ios/src/MGLMapView+Impl.mm
Outdated
| @@ -4,7 +4,8 @@ | |||
| #import "NSBundle+MGLAdditions.h" | |||
|
|
|||
| #if TARGET_OS_IPHONE || TARGET_OS_SIMULATOR | |||
| #import "MMEEventsManager.h" | |||
| #import <MapboxMobileEvents/MapboxMobileEvents.h> | |||
| //#import "MMEEventsManager.h" | |||
There was a problem hiding this comment.
nit: please remove unused code
This was referenced Nov 25, 2019
Added some TODOs since my enviroment isn't being setup properly. StartUpDelay is all handled within MME now. baseURL should be set in the info plist using key MMEEventsServiceURL isMetricsEnabledInSimulator should be set in the info plist using key MMECollectionEnabledInSimulator
julianrex
force-pushed
the
jrex-telemetry-integration
branch
from
52f5d20 to
c9c72b8
Compare
Closed
This was referenced Jan 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test integration of Mapbox Mobile Events as a dependency.
This PR adds
mapbox-events-iosas a separate project to the Xcode workspace, and links with theMapboxMobileEvents.framework:github "mapbox/mapbox-events-ios" == 0.10.1-alphain your Cartfile. It is still TBD how the Carthage dependency will be specified.mapbox-ios-sdk-5.6.0-alpha.1-dynamic-with-events.zip) contains theMapboxMobileEvents.framework; please install this along withMapbox.frameworkThis PR also bumps the release version to
5.6.0-alpha.1. As with all alphas and betas, it is not recommended for production use.OP:
Required for
alpha.1:mapbox-events-iosMGLMapboxEventswith @rclee's helpOptional for
alpha.1: