Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Support building from source via Carthage #133

Open
julianrex opened this issue Jan 6, 2020 · 3 comments
Open

Support building from source via Carthage #133

julianrex opened this issue Jan 6, 2020 · 3 comments

Comments

@julianrex
Copy link
Contributor

Currently this project does not support being compiled as a local repository by Carthage (as noted in the INSTALL.md).

When we can, we'll be able to specify the mapbox-events-ios framework as a dependency, i.e. it will help address the dependency issue noted here: https://github.com/mapbox/mapbox-gl-native-ios/releases/tag/ios-v5.6.0.

We should consider whether this warrants a SEMVER major change.

This may involve #110.

@julianrex
Copy link
Contributor Author

cc @nishant-karajgikar

@1ec5
Copy link
Contributor

1ec5 commented Jan 9, 2020

We should consider whether this warrants a SEMVER major change.

#60 was a semver-major change in disguise, but I don’t know if adding support for building from source would be. Under which scenarios would someone following the current installation instructions result in a broken build after running carthage update?

@1ec5
Copy link
Contributor

1ec5 commented Jan 10, 2020

#143 would also point Carthage to this repository but wouldn’t entail building from source. In my opinion, it gets us most of the benefits of building from source without the attendant build system changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants