Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate camera easing into main render loop #5743

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Integrate camera easing into main render loop #5743

merged 1 commit into from
Nov 27, 2017

Conversation

jfirebaugh
Copy link
Contributor

Fixes #4670. Alternative to #5742.

@jfirebaugh jfirebaugh merged commit d837781 into master Nov 27, 2017
@jfirebaugh jfirebaugh deleted the fix-4670 branch November 27, 2017 17:31
@andy-mcdonald
Copy link

@jfirebaugh - Apologies for asking, but can you provide any timeline for when the next version (v0.42.3?) of mapbox-gl will be released? My team is working on a Mapbox-powered mobile web application (for a high profile client) that is due to launch on December 16th and we really need Markers to be stable.

I tried to run the build scripts from the master branch and manually patch them into the dist folder within the node module, but mapbox-gl.js is throwing an Uncaught Error: can't deserialize object of anonymous class and the map tiles are not displayed. Swapping in mapbox-gl-dev.js doesn't seem to have the new fix. Any ideas how I can get this working?

Again, sorry for pushing on this - I realize it's not practical to release a new version for every issue that gets resolved.

@bicubic
Copy link

bicubic commented Jan 2, 2018

I'm not 100% sure yet, but I think this change caused a regression where the map.transform updates lag by 1 frame behind the move event only during camera easing. I have an application that works fine on 0.34.0 but transforms are 1 frame late during easing on 0.43.0.

@mourner Can you please help me figure out where map.transform is being currently updated so I can investigate further?

@mourner
Copy link
Member

mourner commented Jan 3, 2018

@bicubic mostly in https://github.com/mapbox/mapbox-gl-js/blob/master/src/ui/camera.js, but also in some handler code like https://github.com/mapbox/mapbox-gl-js/blob/master/src/ui/handler/drag_pan.js#L126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants