Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zooming with scroll wheel during pan ease resets pan action. #6668

Closed
bicubic opened this issue May 15, 2018 · 6 comments
Closed

Zooming with scroll wheel during pan ease resets pan action. #6668

bicubic opened this issue May 15, 2018 · 6 comments
Labels

Comments

@bicubic
Copy link

bicubic commented May 15, 2018

This issue is not present in 0.32.0, so I believe it's a regression caused by pan/zoom ease handling.

mapbox-gl-js version:
0.45.0

browser:
Confirmed in Chrome, Firefox. Expect bug is not browser specific.

Steps to Trigger Behavior

  1. Initiate a pan ease with mouse drag + inertia
  2. While pan easing animation is in progress, scroll mouse wheel to initiate a zoom ease

Link to Demonstration

Can be replicated in any demos which allow panning and zooming.

Expected Behavior

Zoom and pan animations should be cumulative

Actual Behavior

The pan animation will stop while the zoom is in progress, and then jerk to the new eased position

@averas
Copy link
Contributor

averas commented Jun 11, 2018

Probably the same root cause, but wanted to mention this on the issue as well.

When initiating an animation programatically, for example with map.easeTo(), mouse wheel zooming does not interrupt the animation, which causes weird UX.

Demonstrated here (start mouse wheel/touch pad zooming during animation):

https://codepen.io/anon/pen/ZRevPa

This may be more of an upgrade blocker for applications than the original issue, especially for applications heavily dependent on animations.

@averas
Copy link
Contributor

averas commented Jun 11, 2018

This seems to be a regression not present in <0.45.0.

@bicubic
Copy link
Author

bicubic commented Jun 12, 2018

It may be related to #5743

@mourner
Copy link
Member

mourner commented Jul 25, 2018

This is no longer reproducible in v0.47 (although I don't remember the exact PR that fixed it).

@mourner mourner closed this as completed Jul 25, 2018
@clemishow
Copy link

clemishow commented Jul 26, 2018

I'm on v0.47 and I still have the issue.
Mozilla/5.0 (Linux; Android 8.0; SM-G960F Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Crosswalk/23.53.589.4 Mobile Safari/537.36

@mourner
Copy link
Member

mourner commented Jul 26, 2018

I might have misunderstood the issue — I can no longer reproduce the jerking motion when zooming during panning inertia, it just stops the inertia and zooms. Zoom and inertia are not cumulative, like the original issue requests, but I think they shouldn't be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants