Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GeoJSON rendering in alternate projections #11146

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Conversation

mourner
Copy link
Member

@mourner mourner commented Oct 20, 2021

Fixes an issue where GeoJSON layers were weirdly truncated on alternate projections — the issue was that tile buffers were destroyed on tile load, and painter fell back to mercator bounds for the stencil clipping.

The PR makes tile bounds creation lazy, so that it's only done when the tile is loaded. This also closes #11138 by avoiding creating tile buffers for tiles that never finished loading, an optimization.

@mourner mourner requested a review from ansis October 20, 2021 16:58
@ansis ansis requested a review from karimnaaji October 20, 2021 18:02
@karimnaaji karimnaaji merged commit 64944a3 into main Oct 20, 2021
@karimnaaji karimnaaji deleted the fix-projections-geojson branch October 20, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create tile bounds buffers lazily
3 participants