Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create tile bounds buffers lazily #11138

Closed
ansis opened this issue Oct 19, 2021 · 0 comments · Fixed by #11146
Closed

create tile bounds buffers lazily #11138

ansis opened this issue Oct 19, 2021 · 0 comments · Fixed by #11146
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Milestone

Comments

@ansis
Copy link
Contributor

ansis commented Oct 19, 2021

A potential optimization: we should be able to create tile bound buffers only for tiles that are in the 'loaded' state, on-demand for visible tiles. Creating the tile bounds buffer can be a non-trivial amount of work. These buffers are created in the tile constructor, but tiles may never reach the 'loaded' state, resulting in these buffers being created and destroyed wastefully.

this._makeTileBoundsBuffers(painter.context, projection);

@ansis ansis added the performance ⚡ Speed, stability, CPU usage, memory usage, or power usage label Oct 19, 2021
@mourner mourner added this to the projections milestone Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants