Add explicit boolean typecast for boolean types (mysql fix) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See PR #52 - hopefully fixes this. It was performing the wrong typecast - it was finding that booleans are stored in MySQL as TINYINT, and performing the wrong type conversion as a consequence. |
|
Since the test suite runs on mysql2 by now, I assume this has been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incomplete PR and still needs work, but it fixes the immediate problem we had, and I'm submitting it to get the conversation started.
When running the test suite under the mysql2 driver there are 24 test failures. With this pull request there are 14 test failures.
Some work needs to be done to get the test suite running under mysql2, I think.