Broken behavior with boolean attributes in rails 4.2

[vevisystems]

After upgrade to rails 4.2, boolean attributes seem to be broken. Even if I do not check a checkbox, it is always interpreted as a "true" value. For instance, this validation always passes:

class AgreeForm < ActiveType::Object
....
attribute :agree, :boolean
validates :agree, :presence => true
end

Any clue?

[vevisystems]

It only happens with mysql database and mysql2 adapter.

[vevisystems]

It seems mysql2 adapter maps boolean values to 1-byte integer, so "false" gets converted to 0. Unfortunate as 0 is true in ruby. There is an obvious workaround (just checking for 0) but we would like it to be fixed... thanks in advance, this is a really great gem and we feel it specially useful for large applications,

[triskweline]

I'm afraid we cannot reproduce this issue.
I added a test for the indended behavior, it passes.

Closing this issue for now. If you'd like to reopen it, please submit a PR with a failing test.

[vevisystems]

Have you tried your test with a Mysql database and mysql2 adapter instead of sqlite?

[mgraham]

I am also having this problem. Also using the mysql2 adapter.

I've got the ActiveType test suite running with mysql2 and there are 24 failing tests. With the following change, I cleared up 10 of them:

diff --git a/lib/active_type/type_caster.rb b/lib/active_type/type_caster.rb
index 4ea45a8..883f4c7 100644
--- a/lib/active_type/type_caster.rb
+++ b/lib/active_type/type_caster.rb
@@ -25,6 +25,12 @@ module ActiveType
         else
           native_type_cast_from_user(value)
         end
+      when :boolean
+        if value 
+          true
+        else
+          false
+        end
       when :timestamp, :datetime
         time = native_type_cast_from_user(value)
         if time && ActiveRecord::Base.time_zone_aware_attributes

I don't know if that's the right way to fix things, and it would be nice to clean up the other errors as well.

Should I make an issue about getting the test suite running under mysql2? Or should this issue be reopened?

[mgraham]

Incomplete pull request: #35