Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 addon #2604

Merged
merged 55 commits into from
Aug 18, 2023
Merged

V2 addon #2604

merged 55 commits into from
Aug 18, 2023

Conversation

BobrImperator
Copy link
Collaborator

@BobrImperator BobrImperator commented Jul 14, 2023

  • Migrates ESA to v2 addon
  • introduces 'test-esa' package which is the extracted tests from ember-simple-auth implementation.
  • fixes mock server
  • Removes import fetch from 'fetch' from ESA, we're using native fetch now.
  • Wraps async functions with @ember/test-waiters
  • Copies README and LICENSE to the project during deploy
  • Sets pnpm resolution-mode to highest
    https://pnpm.io/npmrc#resolution-mode
  • Removes usage of Ember.testing and uses isTesting macro instead
  • Removes ember-get-config seems to not be working in v2 addons
  • Removes remaining global Ember references

@BobrImperator BobrImperator marked this pull request as ready for review July 14, 2023 22:26
@BobrImperator BobrImperator requested review from marcoow and mansona July 14, 2023 22:26
@BobrImperator BobrImperator force-pushed the v2-addon branch 2 times, most recently from 2b743d9 to 52e8b9c Compare July 15, 2023 12:37
@BobrImperator BobrImperator force-pushed the v2-addon branch 2 times, most recently from daf970b to bcaaa97 Compare August 18, 2023 11:44
@BobrImperator BobrImperator merged commit 7f33a6a into master Aug 18, 2023
@BobrImperator BobrImperator deleted the v2-addon branch August 18, 2023 11:59
@BobrImperator
Copy link
Collaborator Author

Thanks @mansona @lolmaus @NullVoxPopuli for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants