Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ember simple auth to v2 addon #2490

Conversation

BobrImperator
Copy link
Collaborator

TODO

  • remove torii, it's deprecated and old. There are also efforts made in https://github.com/adopted-ember-addons/torii
  • remove session-setu-method usage, previously i twas generated during build, but since mixins and initializers are going away, the dependency can be removed
  • instruct build to alias ember-fetch to fetch
ERROR in ../../../../../../../../../../Users/bobrystoteles/Projects/oss/fork-ember-simple-auth/packages/ember-simple-auth/dist/authenticators/devise.js 3:0-26
Module not found: Error: Can't resolve 'fetch' in '/Users/bobrystoteles/Projects/oss/fork-ember-simple-auth/packages/ember-simple-auth/dist/authenticators'
 @ ./tests/unit/authenticators/devise-test.js 2:0-61 9:20-33 31:24-37 134:22-35
 @ ./assets/test.js 230:13-67

ERROR in ../../../../../../../../../../Users/bobrystoteles/Projects/oss/fork-ember-simple-auth/packages/ember-simple-auth/dist/authenticators/oauth2-password-grant.js 3:0-26
Module not found: Error: Can't resolve 'fetch' in '/Users/bobrystoteles/Projects/oss/fork-ember-simple-auth/packages/ember-simple-auth/dist/authenticators'
 @ ./tests/unit/authenticators/oauth2-password-grant-test.js 2:0-89 18:20-46 394:26-52
 @ ./assets/test.js 236:13-82

ERROR in ../../../../../../../../../../Users/bobrystoteles/Projects/oss/fork-ember-simple-auth/packages/ember-simple-auth/dist/configuration.js 1:0-79
Module not found: Error: Can't resolve 'ember-simple-auth/use-session-setup-method' in '/Users/bobrystoteles/Projects/oss/fork-ember-simple-auth/packages/ember-simple-auth/dist'
 @ ./tests/unit/initializers/setup-session-restoration-test.js 5:0-60 24:37-72 25:6-41 28:6-41 31:6-41 44:6-41
 @ ./assets/test.js 248:13-84

ERROR in ../../node_modules/torii/load-initializers.js 3:0-62
Module not found: Error: Can't resolve './initializers/initialize-torii' in '$TMPDIR/embroider/e962e9/node_modules/torii'
 @ ./assets/test-app.js 740:13-69

ERROR in ../../node_modules/torii/load-initializers.js 4:0-79
Module not found: Error: Can't resolve './initializers/initialize-torii-callback' in '$TMPDIR/embroider/e962e9/node_modules/torii'
 @ ./assets/test-app.js 740:13-69

ERROR in ../../node_modules/torii/load-initializers.js 5:0-77
Module not found: Error: Can't resolve './initializers/initialize-torii-session' in '$TMPDIR/embroider/e962e9/node_modules/torii'
 @ ./assets/test-app.js 740:13-69

ERROR in ../../node_modules/torii/load-initializers.js 6:0-63
Module not found: Error: Can't resolve './instance-initializers/setup-routes' in '$TMPDIR/embroider/e962e9/node_modules/torii'
 @ ./assets/test-app.js 740:13-69

ERROR in ../../node_modules/torii/load-initializers.js 7:0-67
Module not found: Error: Can't resolve './instance-initializers/walk-providers' in '$TMPDIR/embroider/e962e9/node_modules/torii'
 @ ./assets/test-app.js 740:13-69

@BobrImperator BobrImperator mentioned this pull request Nov 29, 2022
@BobrImperator
Copy link
Collaborator Author

Closing in favor of #2604

@BobrImperator BobrImperator deleted the migrate-ember-simple-auth-to-v2-addon branch July 14, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant