Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(breaking): drop ember < v3.28 and IE11 support #2544

Merged
merged 4 commits into from
Apr 28, 2023
Merged

feat(breaking): drop ember < v3.28 and IE11 support #2544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fe8f3f
feat(breaking): remove ember-try scenarios versions < v3.28
BobrImperator Apr 21, 2023
a5c7953
chore: prolong torii deprecation period
BobrImperator Apr 21, 2023
7e91b64
chore(ci): test ember-canary, add ember-release to no-failure matrix
BobrImperator Apr 21, 2023
d66d454
chore: remove torii from 4.12 ember-try and onwards
BobrImperator Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ jobs:
- classic-test-app
- test-app
test-suite:
- test:one ember-lts-3.12
- test:one ember-lts-3.16
- test:one ember-lts-3.20
- test:one ember-lts-3.24
- test:one ember-lts-3.28
- test:one ember-4.0
- test:one ember-lts-4.4
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ __[Ember Simple Auth API docs](http://ember-simple-auth.com/api/)__

__[![Discord](https://img.shields.io/discord/480462759797063690.svg?logo=discord)](https://discord.gg/zT3asNS)__

Ember Simple Auth __supports all Ember.js versions starting with 3.12.__
Ember Simple Auth __supports all Ember.js versions starting with 3.28.__
__Doesn't support IE11__
Node __>=16 is required__

# Ember Simple Auth
Expand Down
2 changes: 1 addition & 1 deletion packages/ember-simple-auth/addon/authenticators/torii.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import BaseAuthenticator from './base';

deprecate('Ember Simple Auth: The Torii authenticator is deprecated.', false, {
id: 'ember-simple-auth.authenticators.torii',
until: '6.0.0',
until: '7.0.0',
for: 'ember-simple-auth',
since: {
enabled: '4.2.0'
Expand Down
120 changes: 22 additions & 98 deletions packages/ember-simple-auth/config/ember-try.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,63 +15,6 @@ module.exports = function() {
return {
useYarn: true,
scenarios: [
{
name: 'ember-lts-3.12',
npm: {
devDependencies: {
'ember-cli': '~3.28.0',
'ember-data': '~3.12.0',
'ember-source': '~3.12.0',
'ember-inflector': '~3.0.1',
'@ember/string': '~3.0.1',
'torii': '^0.10.0',
'ember-engines': '0.8.21',
'@ember/legacy-built-in-components': null,
},
},
},
{
name: 'ember-lts-3.16',
npm: {
devDependencies: {
'ember-cli': '~3.28.0',
'ember-data': '~3.16.0',
'ember-source': '~3.16.0',
'ember-inflector': '~3.0.1',
'@ember/string': '~3.0.1',
'torii': '^0.10.0',
'ember-engines': '0.8.21',
'@ember/legacy-built-in-components': null,
},
},
},
{
name: 'ember-lts-3.20',
npm: {
devDependencies: {
'ember-cli': '~3.28.0',
'ember-data': '~3.20.0',
'ember-source': '~3.20.0',
'ember-inflector': '~3.0.1',
'@ember/string': '~3.0.1',
'torii': '^0.10.0',
'ember-engines': '0.8.21',
'@ember/legacy-built-in-components': null,
},
},
},
{
name: 'ember-lts-3.24',
npm: {
devDependencies: {
'ember-cli': '~3.28.0',
'ember-data': '~3.24.0',
'ember-source': '~3.24.0',
'ember-engines': '0.8.21',
'@ember/legacy-built-in-components': null,
},
},
},
{
name: 'ember-lts-3.28',
npm: {
Expand All @@ -86,31 +29,19 @@ module.exports = function() {
name: 'ember-4.0',
npm: {
devDependencies: {
'ember-cli': '~3.28.0',
'ember-cli': '~4.0.0',
'ember-data': '~4.0.0',
'ember-source': '~4.0.0',
'ember-auto-import': '^2.2.3',
webpack: '^5.0.0',
'@ember/test-helpers': '^2.4.2',
'ember-qunit': '^5.1.4',
qunit: '^2.17.2',
'ember-cli-app-version': '~5.0.0',
},
},
},
{
name: 'ember-lts-4.4',
npm: {
devDependencies: {
'ember-cli': '~3.28.0',
'ember-cli': '~4.4.0',
'ember-data': '~4.4.0',
'ember-source': '~4.4.0',
'ember-auto-import': '^2.2.3',
webpack: '^5.0.0',
'@ember/test-helpers': '^2.4.2',
'ember-qunit': '^5.1.4',
qunit: '^2.17.2',
'ember-cli-app-version': '~5.0.0',
},
},
},
Expand All @@ -121,12 +52,17 @@ module.exports = function() {
'ember-cli': '~4.8.0',
'ember-data': '~4.8.0',
'ember-source': '~4.8.0',
'ember-auto-import': '^2.2.3',
webpack: '^5.0.0',
'@ember/test-helpers': '^2.4.2',
'ember-qunit': '^5.1.4',
qunit: '^2.17.2',
'ember-cli-app-version': '~5.0.0',
},
},
},
{
name: 'ember-4.12',
npm: {
devDependencies: {
'ember-cli': '~4.12.0',
'ember-source': '~4.12.0',
// ember-data >=4.12 breaks under fastboot
// 'ember-data': '~4.12.0',
},
},
},
Expand All @@ -135,14 +71,10 @@ module.exports = function() {
npm: {
devDependencies: {
'ember-cli': 'latest',
'ember-data': 'latest',
// ember-data >=4.12 breaks under fastboot
// 'ember-data': 'latest',
'ember-source': releaseUrl,
'ember-auto-import': '^2.2.3',
webpack: '^5.0.0',
'@ember/test-helpers': '^2.4.2',
'ember-qunit': '^5.1.4',
qunit: '^2.17.2',
'ember-cli-app-version': '~5.0.0',
torii: null,
},
},
},
Expand All @@ -151,14 +83,10 @@ module.exports = function() {
npm: {
devDependencies: {
'ember-cli': 'beta',
'ember-data': 'beta',
// ember-data >=4.12 breaks under fastboot
// 'ember-data': 'beta',
'ember-source': betaUrl,
'ember-auto-import': '^2.2.3',
webpack: '^5.0.0',
'@ember/test-helpers': '^2.4.2',
'ember-qunit': '^5.1.4',
qunit: '^2.17.2',
'ember-cli-app-version': '~5.0.0',
torii: null,
},
},
},
Expand All @@ -167,14 +95,10 @@ module.exports = function() {
npm: {
devDependencies: {
'ember-cli': 'beta',
'ember-data': 'canary',
// ember-data >=4.12 breaks under fastboot
// 'ember-data': 'canary',
'ember-source': canaryUrl,
'ember-auto-import': '^2.2.3',
webpack: '^5.0.0',
'@ember/test-helpers': '^2.4.2',
'ember-qunit': '^5.1.4',
qunit: '^2.17.2',
'ember-cli-app-version': '~5.0.0',
torii: null,
},
},
},
Expand Down
2 changes: 1 addition & 1 deletion packages/ember-simple-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"ember-addon": {
"configPath": "tests/dummy/config",
"versionCompatibility": {
"ember": ">=3.12"
"ember": ">=3.28"
}
},
"peerDependencies": {
Expand Down