feat(breaking): drop ember < v3.28 and IE11 support #2544

BobrImperator · 2023-04-21T04:22:38Z

Majority of Ember.js users seem to be already on v4.
Supporting V3 makes it difficult to support the newest v5.

Drop IE11 support
Changes compatibility to =>3.28
Removes < v3.28 ember-try scenarios
Cleans up ember-try scenarios from redundant package declarations
Doesn't test against ember-data >= 4.12 which fails under fastboot Fastboot incompatible with modern state of the ecosystem ember-fastboot/ember-cli-fastboot#913

#2545 should fix some of the failing scenarios.
Related issue in ember-cookies that tracks fastboot compatibility mainmatter/ember-cookies#791

TODO
make sure feat(breaking): drop Ember v3 versions ember-cookies#797 is released so ESA can bump the dependency before releasing.

marcoow

🎉

BobrImperator added the breaking label Apr 21, 2023

BobrImperator requested a review from marcoow April 21, 2023 04:23

BobrImperator force-pushed the chore-drop-ember-v3 branch 5 times, most recently from f3f7ebc to 87b065c Compare April 21, 2023 19:27

BobrImperator requested review from marcoow and removed request for marcoow April 21, 2023 20:25

marcoow approved these changes Apr 24, 2023

View reviewed changes

BobrImperator force-pushed the chore-drop-ember-v3 branch from 20bbc7d to 5e18043 Compare April 28, 2023 09:39

BobrImperator changed the title ~~feat(breaking): drop ember v3 support~~ feat(breaking): drop ember < v3.28 support Apr 28, 2023

BobrImperator changed the title ~~feat(breaking): drop ember < v3.28 support~~ feat(breaking): drop ember < v3.28, IE11 support Apr 28, 2023

BobrImperator force-pushed the chore-drop-ember-v3 branch 3 times, most recently from bc105b6 to 8a2a9ba Compare April 28, 2023 09:53

BobrImperator changed the title ~~feat(breaking): drop ember < v3.28, IE11 support~~ feat(breaking): drop ember < v3.28 and IE11 support Apr 28, 2023

BobrImperator added 4 commits April 28, 2023 12:49

feat(breaking): remove ember-try scenarios versions < v3.28

1fe8f3f

chore: prolong torii deprecation period

a5c7953

chore(ci): test ember-canary, add ember-release to no-failure matrix

7e91b64

chore: remove torii from 4.12 ember-try and onwards

d66d454

BobrImperator force-pushed the chore-drop-ember-v3 branch from 8a2a9ba to d66d454 Compare April 28, 2023 10:50

BobrImperator merged commit 81ebe57 into mainmatter:master Apr 28, 2023

BobrImperator deleted the chore-drop-ember-v3 branch April 28, 2023 12:33

Provide feedback