-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "deprecate" to import from @ember/debug #2317
Update "deprecate" to import from @ember/debug #2317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
fffd8e6
to
c58d562
Compare
Seems like we generally have some test failures that are common across PRs? Are they blocking? |
@snewcomer these seem to be related to global Ember usage which has been deprecated for a while, and because of that ember-beta seems to be failing because it's usage must've been removed, not sure atm though. |
@@ -62,7 +62,7 @@ | |||
"ember-sinon": "~5.0.0", | |||
"ember-source": "~3.18.0", | |||
"ember-source-channel-url": "^2.0.1", | |||
"ember-test-selectors": "^4.0.0", | |||
"ember-test-selectors": "^6.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was working on getting the tests passing. Looks like they are failing on the main branch so hopefully I can resolve here 👉
This reverts commit 050737e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to update all of the usages of the old import in this PR?
@marcoow oh my how I missed that :). Fixed |
@snewcomer there are some linter failures now because duplicated imports… |
ref #2315 (comment)