[2302] put internal-session into DI system #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobrImperator
commented
Aug 13, 2021
| @@ -147,19 +135,19 @@ describe('SessionService', () => { | |||
| it("is read from the session's content", function() { | |||
| session.set('some', 'data'); | |||
|
|
|||
| expect(sessionService.get('data')).to.eql({ some: 'data' }); | |||
| expect(sessionService.get('data')).to.eql({ some: 'data', authenticated: {} }); | |||
There was a problem hiding this comment.
This is a valid change IMO since the internal-session initializes it's content to { authenticated: {} } while the test session proxy initialized an empty object instead.
BobrImperator
commented
Aug 13, 2021
| @@ -808,11 +804,4 @@ describe('InternalSession', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| it('does not share the content object between multiple instances', function() { | |||
There was a problem hiding this comment.
It didn't make sense to me since there's only 1 session:main in the app anyway? Which is even more true with us only looking it up once in session service.
BobrImperator
force-pushed
the
2302-use-di-part-2
branch
from
7f2481a
to
7406501
Compare
snewcomer
approved these changes
Aug 18, 2021
Turbo87
approved these changes
Aug 21, 2021
|
Should we also take care of this deprecation or do that in a separate PR? |
|
@snewcomer seems unrelated to the DI stuff, so I'd suggest to do that in a dedicated PR |
|
Thanks a lot @BobrImperator |
|
Thank you! Is there a new release for this? |
|
@Turbo87 or @sdebarros would you mind cutting a release that includes this please? |
|
🎉 Thank you @BobrImperator ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2302