Extract destruction of the modals effects into a method and apply them #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeppelin
force-pushed
the
pichfl/refactor-5
branch
from
196b7fd to
022bc53
Compare
pichfl
force-pushed
the
pichfl/refactor-5
branch
from
022bc53 to
6d7d586
Compare
pichfl
force-pushed
the
pichfl/refactor-5
branch
from
6d7d586 to
03bb1d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "private"
_destroy()method is used when the service instance is destroyed and also in the test helper to tear down any remaining modals between tests.