refactor: Use new destruction method when destroying stray modals

mainmatter · Oct 14, 2022 · 6d7d586 · 6d7d586
1 parent 2482656
commit 6d7d586
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/addon/modal.js b/addon/modal.js
@@ -50,6 +50,12 @@ export default class Modal {
     }
   }
 
+  _destroy() {
+    if (this._componentInstance) {
+      this._componentInstance.destroyModal();
+    }
+  }
+
   then(onFulfilled, onRejected) {
     return this._deferred.promise.then(onFulfilled, onRejected);
   }

diff --git a/addon/services/modals.js b/addon/services/modals.js
@@ -53,7 +53,7 @@ export default Service.extend({
 
   _destroyModals() {
     this._stack.forEach(modal => {
-      modal._remove();
+      modal._destroy();
     });
   },