Test coverage for PR #27589 (E-mail templates) #27606

lbajsarowicz · 2020-04-05T01:37:38Z

Description (*)

Additional Integration Tests coverage for PR provided by @ptylek

Related Pull Requests

Fixed Issues (if relevant)

Use the same greeting as in other Magento Customer emails #27589

Related issues

Integration Tests: DOM Assertion class #27607

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-04-05T01:37:40Z

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

naydav · 2020-04-05T01:41:02Z

dev/tests/integration/testsuite/Magento/Customer/Controller/Account/EmailTemplateTest.php

+        $emailDom->loadHTML($messageContent);
+
+        $emailXpath = new \DOMXPath($emailDom);
+        $greeting = $emailXpath->query('//p[@class="greeting"]')->item(0);


Looks like if '//p[@class="greeting"]' will not found then it will lead to a fatal error
"Call method item() on no-objetc"
Please check it

Addressing the issue.

naydav · 2020-04-05T01:49:21Z

dev/tests/integration/testsuite/Magento/Customer/Controller/Account/EmailTemplateTest.php

+    {
+        $messageContent = $this->getMessageRawContent($message);
+        $emailDom = new \DOMDocument();
+        $emailDom->loadHTML($messageContent);


We can introduce new "assert class" and put in
https://github.com/magento/magento2/tree/2.4-develop/dev/tests/integration/framework/Magento/TestFramework
Assert namespace.

We achieve 2 goals:

working with DOM will be encapsulated ;

we can reuse the "assert" in the other testcases;

Thanks

I'm going to create separate ticket for that point.

I'm going to create separate ticket for that point.

Please link this and a new ticket.

magento-engcom-team · 2020-04-05T02:04:41Z

Hi @naydav, thank you for the review.
ENGCOM-7262 has been created to process this Pull Request
✳️ @naydav, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

lbajsarowicz · 2020-04-17T10:20:53Z

@slavvka Sorry, I haven't noticed your message. Sure I'm going to fix the failing issue.
Also, label is incorrect as original issue was fixed by other contributor, I just covered change with tests.

…27589-email-integration-tests

lbajsarowicz · 2020-04-17T14:10:55Z

@slavvka Failures were not related.

magento-engcom-team · 2020-04-17T18:18:34Z

Hi @slavvka, thank you for the review.
ENGCOM-7262 has been created to process this Pull Request

m2-assistant · 2020-04-18T08:47:25Z

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ptylek and others added 2 commits April 4, 2020 19:28

Use the same greeting as in other Magento Customer emails

1ac923d

magento#27589 Cover with Integration Tests the template changes.

16cb18d

ghost added the Progress: pending review label Apr 5, 2020

magento-engcom-team added Area: Frontend Component: Customer Release Line: 2.4 Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Event: Global-Contribution-Day labels Apr 5, 2020

lbajsarowicz changed the title ~~Test coverage for PR #27589~~ Test coverage for PR #27589 (E-mail templates) Apr 5, 2020

lbajsarowicz mentioned this pull request Apr 5, 2020

Use the same greeting as in other Magento Customer emails #27589

Merged

4 tasks

naydav requested changes Apr 5, 2020

View reviewed changes

ghost assigned naydav Apr 5, 2020

ghost added Progress: needs update and removed Progress: pending review labels Apr 5, 2020

ghost assigned lbajsarowicz Apr 5, 2020

magento#27589 Expect exactly one greeting in the Template

f882122

naydav approved these changes Apr 5, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Apr 5, 2020

lbajsarowicz linked an issue Apr 5, 2020 that may be closed by this pull request

Integration Tests: DOM Assertion class #27607

Closed

lbajsarowicz mentioned this pull request Apr 5, 2020

Fix duplicated footer in Magento_Customer emails #27356

Merged

5 tasks

magento#27589 Fix Static Tests

82224a6

engcom-Alfa self-assigned this Apr 8, 2020

ghost added Progress: on hold and removed Progress: accept labels Apr 10, 2020

ghost added Progress: pending review and removed Progress: on hold labels Apr 10, 2020

Merge remote-tracking branch 'origin/2.4-develop' into test-coverage/…

d4b8083

…27589-email-integration-tests

slavvka approved these changes Apr 17, 2020

View reviewed changes

ghost assigned slavvka Apr 17, 2020

ghost removed the Progress: pending review label Apr 17, 2020

ghost added Progress: ready for testing Progress: testing in progress and removed Progress: ready for testing labels Apr 17, 2020

ghost added Progress: accept and removed Progress: testing in progress labels Apr 17, 2020

magento-engcom-team pushed a commit that referenced this pull request Apr 18, 2020

ENGCOM-7262: Test coverage for PR #27589 (E-mail templates) #27606

5f57f06

magento-engcom-team merged commit 45706d6 into magento:2.4-develop Apr 18, 2020

lbajsarowicz mentioned this pull request Apr 18, 2020

Fixes unstable email integration tests #27892

Merged

4 tasks

magento-engcom-team mentioned this pull request May 1, 2020

Integration Tests: DOM Assertion class #27607

Closed

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test coverage for PR #27589 (E-mail templates) #27606

Test coverage for PR #27589 (E-mail templates) #27606

lbajsarowicz commented Apr 5, 2020 •

edited by slavvka

Loading

m2-assistant bot commented Apr 5, 2020

naydav Apr 5, 2020

lbajsarowicz Apr 5, 2020

naydav Apr 5, 2020

lbajsarowicz Apr 5, 2020

naydav Apr 5, 2020

lbajsarowicz Apr 5, 2020

magento-engcom-team commented Apr 5, 2020

lbajsarowicz commented Apr 17, 2020

lbajsarowicz commented Apr 17, 2020

magento-engcom-team commented Apr 17, 2020

m2-assistant bot commented Apr 18, 2020

Test coverage for PR #27589 (E-mail templates) #27606

Test coverage for PR #27589 (E-mail templates) #27606

Conversation

lbajsarowicz commented Apr 5, 2020 • edited by slavvka Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Related issues

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Apr 5, 2020

naydav Apr 5, 2020

Choose a reason for hiding this comment

lbajsarowicz Apr 5, 2020

Choose a reason for hiding this comment

naydav Apr 5, 2020

Choose a reason for hiding this comment

lbajsarowicz Apr 5, 2020

Choose a reason for hiding this comment

naydav Apr 5, 2020

Choose a reason for hiding this comment

lbajsarowicz Apr 5, 2020

Choose a reason for hiding this comment

magento-engcom-team commented Apr 5, 2020

lbajsarowicz commented Apr 17, 2020

lbajsarowicz commented Apr 17, 2020

magento-engcom-team commented Apr 17, 2020

m2-assistant bot commented Apr 18, 2020

lbajsarowicz commented Apr 5, 2020 •

edited by slavvka

Loading