Use the same greeting as in other Magento Customer emails #27589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ptylek. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
ghost
added
the
magento-engcom-team
added
Area: Frontend
Component: Customer
Release Line: 2.4
Partner: creativestyle
partners-contribution
lbajsarowicz
added a commit
to lbajsarowicz/magento2-contributions
that referenced
this pull request
Apr 5, 2020
4 tasks
lbajsarowicz
added a commit
to lbajsarowicz/magento2-contributions
that referenced
this pull request
Apr 5, 2020
lbajsarowicz
added a commit
to lbajsarowicz/magento2-contributions
that referenced
this pull request
Apr 5, 2020
|
Hi @lbajsarowicz. How would you like to proceed with this one? Should @ptylek copy the tests over to this PR and close yours? Trying to figure out the best way to process both PRs. Thank you. |
|
If you merge mine, his would be also tagged as merged. |
magento-engcom-team
added a commit
that referenced
this pull request
Apr 18, 2020
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 18, 2020
magento-engcom-team
added a commit
that referenced
this pull request
Apr 18, 2020
…op expedited Accepted Community Pull Requests: - #26293: Bugfix - Customer emails are not being sent from admin if customer is from store "0" (by @matheusgontijo) - #27606: Test coverage for PR #27589 (E-mail templates) (by @lbajsarowicz) - #27841: [MFTF] Remove redundant Index and Flush Cache action group (by @Usik2203) - #27692: [MFTF] Use ActionGroup for checking category save success message. (by @Usik2203) - #27843: [MFTF] Added assertion to AssertAdminSuccessLoginActionGroup (by @Usik2203)
|
Hi @ptylek, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
In all Magento_Customer emails, there is proper greeting using customer name instead of
Hello.Related Pull Requests
These changes were moved from #27356 as the other PR is focused on duplicated content, not on changes to greeting.
Fixed Issues (if relevant)
not found
Manual testing scenarios (*)
Questions or comments
All emails use
<p class="greeting">{{trans "%name," name=$customer.name}}</p>Maybe we can switch it to
<p class="greeting">{{var customer.name}},</p>?
That would wider the scope of this PR in order to check all emails.
Contribution checklist (*)