Added improvements to category url key validation logic

[sergiy-v]

Description

Improved validate URL key logic for category.

I have added improvements to validate URL key logic for category instead of adding a solution for Thai language because of:

• \Magento\Framework\Filter\Translit can not provide translation for Thai language (the convert table does not contain Thai symbols). It will be hard to add and manage all needed symbols for all languages to the convert table.
• Magento Community Engineering provides on localization extensions like Japanese Localization which provide a solution for such cases (has plugin to filter value in other way).

Fixed Issues

#13689

Manual testing scenarios

See #13689 issue description for details.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

Hi @sergiy-v,
Your change improves message, however you still will not be able to create category -> it's not fixing the listed issue.

Could you update your changes?

[sergiy-v]

Hi @sergiy-v,
Your change improves message, however you still will not be able to create category -> it's not fixing the listed issue.

Could you update your changes?

Hello @ihor-sviziev,
Yes, it's not fixed the issue (not providing translation) as I mentioned in description. I have added the reasons why the logic should not be changed.
I'll be happy to add a solution, but as discussed in related tasks some expectation can be wrong, the other changes can be incompatible due to backward compatibility or so.
That's why I suggest to fix the issue by providing more details to the admin user in error message to solve the issue.
@ihor-sviziev please suggest the possible solution and I'll try to add it to PR.

Thank you.

[ihor-sviziev]

@sergiy-v i got your point, seems reasonable. Will review your PR little bit later

[ihor-sviziev]

Hi @sergiy-v,
Please review my comments and static test failures (except copy paste failure, this is known issue) and update your changes accordingly

[sergiy-v]

Hi @sergiy-v,
Please review my comments and static test failures (except copy paste failure, this is known issue) and update your changes accordingly

Thanks for suggestions, the changes has been added. I believe the tests errors not related to the changes, please check it.

Thank you.

[ihor-sviziev]

Hi @lenaorobei @slavvka,
could you give some more info why dB compare test fails, all results inside are green. Tried restarting, but the same result

[ihor-sviziev]

Oh, looks after merging 2.4 develop the issue is gone. Thank you @lenaorobei !

[ihor-sviziev]

Looks like test failures are not related to changes from this PR

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7208 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[engcom-Echo]

Failed functional tests not related to the changes in this PR - comment

[m2-assistant]

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.