Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot create catagory's name with thai langauge #13689

Closed
juniorkidza1994 opened this issue Feb 16, 2018 · 12 comments · Fixed by #27412
Closed

Cannot create catagory's name with thai langauge #13689

juniorkidza1994 opened this issue Feb 16, 2018 · 12 comments · Fixed by #27412
Assignees
@sergiy-v @chohanbhagchand
Labels
Component: Url Fixed in 2.4.x The issue has been fixed in 2.4-develop branch good first issue Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@juniorkidza1994
Copy link

juniorkidza1994 commented Feb 16, 2018 •
edited by ihor-sviziev
Loading

Preconditions

  1. Magento 2.2.2
  2. PHP 7.1.11

Steps to reproduce

  1. Create new sub category
  2. Use thai language in name field

Expected result

  1. get new category with thai name language Or have a meaningful message that we need to fix url key manually

Actual result

  1. get error in picture
    screen shot 2561-02-16 at 3 28 43 pm
    And message not clear at all
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 16, 2018
@magento-engcom-team
Copy link
Contributor

@juniorkid, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Feb 16, 2018
@otokoalan
Copy link

otokoalan commented Feb 20, 2018 •
edited
Loading

I'm working on it.
#MLAU18

@ghost ghost self-assigned this Apr 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2019 •
edited by ghost
Loading

Hi @engcom-backlog-nazar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost
Copy link

ghost commented Apr 5, 2019

Still reproducing at 2.3-develop branch.
DeepinScreenshot_select-area_20190405104325

@ghost ghost removed their assignment Apr 5, 2019
@shikhamis11 shikhamis11 mentioned this issue Apr 7, 2019
Closed
@abhi-ranosys
Copy link

I am working on this at #dmcdindia19

@abhi-ranosys abhi-ranosys self-assigned this May 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @abhi-ranosys. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@pradeep-wagento
Copy link
Contributor

I am working on this at #dmcdindia19

pradeep-wagento added a commit to pradeep-wagento/magento2 that referenced this issue May 4, 2019
@pradeep-wagento
magento#13689 - category url key accept all language including specia…
84d390c 
…l charaters
@pradeep-wagento pradeep-wagento mentioned this issue May 4, 2019
Closed
4 tasks
@ghost ghost assigned pradeep-wagento May 4, 2019
abhi-ranosys pushed a commit to abhi-ranosys/magento2 that referenced this issue May 4, 2019
Fixed Issue magento#13689
690fdb8
@ghost ghost unassigned pradeep-wagento May 22, 2019
@ghost ghost unassigned abhi-ranosys Sep 27, 2019
@engcom-Bravo engcom-Bravo self-assigned this Jan 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @engcom-Bravo. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

@engcom-Bravo engcom-Bravo added Component: Url and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 2, 2020
@engcom-Bravo engcom-Bravo added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 2, 2020
@ghost ghost unassigned engcom-Bravo Jan 2, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-30158 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@chohanbhagchand chohanbhagchand self-assigned this Jan 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 18, 2020

Hi @chohanbhagchand. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

chohanbhagchand pushed a commit to chohanbhagchand/magento2 that referenced this issue Jan 18, 2020
Cannot create catagory's name with thai langauge magento#13689
fcdc291
@sergiy-v sergiy-v self-assigned this Mar 23, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 23, 2020

Hi @sergiy-v. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

@sergiy-v sergiy-v mentioned this issue Mar 24, 2020
Merged
4 tasks
@sergiy-v sergiy-v linked a pull request Mar 24, 2020 that will close this issue
Added improvements to category url key validation logic #27412
Merged
4 tasks
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label May 1, 2020
@magento-engcom-team
Copy link
Contributor

Hi @juniorkid. Thank you for your report.
The issue has been fixed in #27412 by @sergiy-v in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

This was referenced May 9, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergiy-v sergiy-v

@chohanbhagchand chohanbhagchand

Labels
Component: Url Fixed in 2.4.x The issue has been fixed in 2.4-develop branch good first issue Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added improvements to category url key validation logic sergiy-v/magento2
9 participants
@sergiy-v @VladimirZaets @juniorkidza1994 @pradeep-wagento @abhi-ranosys @otokoalan @magento-engcom-team @chohanbhagchand @engcom-Bravo