#27089 Fix issue with returning non-available default limit

[lbajsarowicz]

Description (*)

Fix issue related with returning default value of Limit that is not available

Related Pull Requests

Fixed Issues (if relevant)

1. BUG: getDefaultLimitPerPageValue returns value that is not available #27089

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lbajsarowicz]

@ihor-sviziev We need manual approval for Semantic Version Checker, as I just fixed the return types for methods, from invalid ones. Static Tests fixed.

[ihor-sviziev]

Waiting for approval for SVC failure

[lenaorobei]

Approval request in progress MC-32331.

[ihor-sviziev]

@lenaorobei still no updates in approval process?

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-7453 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Case 1. Grid Mode

Manual testing scenario:

1. Change catalog/frontend/grid_per_page_values to 1,2,5 using CLI
   (Run in console: php bin/magento config:set catalog/frontend/grid_per_page_values 1,2,5);
2. Change catalog/frontend/grid_per_page to 12
   (Run in console: php bin/magento config:set catalog/frontend/list_per_page 12);
3. Get the value of catalog/frontend/grid_per_page_values in your Template

Before:
✖️ getDefaultLimitPerPageValue('grid') returns 12

After:
✔️ getDefaultLimitPerPageValue('grid') returns the lowest of the acceptable values 1

Case 2. List Mode

Manual testing scenario:

1. Change catalog/frontend/list_per_page_values to 3,7,9,13 using CLI
   (Run in console: php bin/magento config:set catalog/frontend/list_per_page_values 3,7,9,13);
2. Change catalog/frontend/list_per_page to 11
   (Run in console: php bin/magento config:set catalog/frontend/list_per_page 11);
3. Get the value of catalog/frontend/list_per_page_values in your Template

Before:
✖️ getDefaultLimitPerPageValue('list') returns 11

After:
✔️ getDefaultLimitPerPageValue('list') returns the lowest of the acceptable values 3

[engcom-Echo]

SVC failure was approved.

[okorshenko]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @okorshenko. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[magento-engcom-team]

Hi @okorshenko, here is your Magento instance.
Admin access: https://i-27093-2-4-develop.instances.magento-community.engineering/admin_b727
Login: 1e3133f8 Password: a673e4b788bb
Instance will be terminated in up to 3 hours.

[okorshenko]

@magento give me test instance

[magento-engcom-team]

Hi @okorshenko. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @okorshenko, here is your new Magento instance.
Admin access: https://pr-27093.instances.magento-community.engineering/admin_c4f3
Login: ec9c82ce Password: f831b5cd3120
Instance will be terminated in up to 3 hours.

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.