Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: getDefaultLimitPerPageValue returns value that is not available #27089

Closed
lbajsarowicz opened this issue Feb 29, 2020 · 3 comments · Fixed by #27093
Closed

BUG: getDefaultLimitPerPageValue returns value that is not available #27089

lbajsarowicz opened this issue Feb 29, 2020 · 3 comments · Fixed by #27093
Assignees
@lbajsarowicz
Labels
Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@lbajsarowicz
Copy link
Contributor

lbajsarowicz commented Feb 29, 2020 •
edited
Loading

Preconditions (*)

image

As a Store Administrator, you are able to provide the Products per Page on Grid Allowed Values and Products per Page on Grid Default Value. There is no verification, so you can accidentally set the default value to be one of the unavailable options.

Steps to reproduce (*)

  1. Change catalog/frontend/grid_per_page_values to 1,2,5 using CLI
  2. Change catalog/frontend/grid_per_page to 12
  3. Get the value of catalog/frontend/grid_per_page_values in your Template

Expected result (*)

  1. Configuration should return only allowed values, so we expect to return one of the available values (1,2 or 5)

Actual result (*)

  1. Configuration returns value that is not allowed - value of 12
@m2-assistant
Copy link

m2-assistant bot commented Feb 29, 2020

Hi @lbajsarowicz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@lbajsarowicz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 29, 2020
lbajsarowicz added a commit to lbajsarowicz/magento2-contributions that referenced this issue Feb 29, 2020
@lbajsarowicz
magento#27089 Fix issue with returning non-available default limit, c…
17236cc 
…overage with Unit Tests
@lbajsarowicz lbajsarowicz mentioned this issue Feb 29, 2020
Merged
4 tasks
@ghost ghost assigned lbajsarowicz Feb 29, 2020
@okorshenko okorshenko added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 22, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 22, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @okorshenko
Thank you for verifying the issue. Based on the provided information internal tickets MC-33644 were created

Issue Available: @okorshenko, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@okorshenko okorshenko linked a pull request Apr 23, 2020 that will close this issue
#27089 Fix issue with returning non-available default limit #27093
Merged
4 tasks
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Apr 25, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz. Thank you for your report.
The issue has been fixed in #27093 by @lbajsarowicz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

magento-engcom-team added a commit that referenced this issue Apr 25, 2020
@magento-engcom-team
ENGCOM-7453: #27089 Fix issue with returning non-available default li…
c4ec8e4 
…mit #27093

 - Merge Pull Request #27093 from lbajsarowicz/magento2:bugfix/default-limit-not-available
 - Merged commits:
   1. 17236cc
   2. 381ab64
   3. 778fbfb
   4. d3962f2
   5. aec01d8
magento-engcom-team pushed a commit that referenced this issue Apr 25, 2020
@slavvka
ENGCOM-7453: #27089 Fix issue with returning non-available default li…
5c440b9 
…mit #27093
This was referenced May 9, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbajsarowicz lbajsarowicz

Labels
Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#27089 Fix issue with returning non-available default limit lbajsarowicz/magento2-contributions
4 participants
@lbajsarowicz @sdzhepa @okorshenko @magento-engcom-team