Move additional dependencies from private getters to constructor - Magento_Captcha

[Bartlomiejsz]

Description (*)

This PR moves additionally introduced dependencies from private getter methods into constructor in Magento_Captcha module.

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[aleron75]

Hello @Bartlomiejsz, thank you for your contribution!

Even if this change doesn't affect a public API, I would recommend to make it as backward compatible as possible, adding the new constructor parameter as last and optional (DataPersistorInterface $dataPersisto = null), with property initialized with object manager if the parameter is not passed.

e.g.

$this->dataPersistor = $dataPersistor ?: ObjectManager::getInstance()->get(DataPeristorInterface::class);

[Bartlomiejsz]

Hello @aleron75, I can change it if it is required, sure, but I believe this would be great to specify final requirements, because almost each PR is processed differently :)
I.e. #26684 was accepted after modifying constructor to be not backward compatible, and in #26269 I was even asked to modify it and remove object manager usage.
What are your thoughts?

[aleron75]

Let me check and get back to you soon, thank you for pointing it out

[aleron75]

Hello @Bartlomiejsz here I am; I verified and I apologize, you are right: we can accept backward-incompatible changes for non-api classes, so we could add new arguments without fallback to Object Manager.

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-6886 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.