Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7065 - page.main.title is translating title #26269

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Fix #7065 - page.main.title is translating title #26269

merged 1 commit into from
Jan 17, 2020

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Jan 5, 2020 •
edited
Loading

Description (*)

This is fix for #7065. To resolve the issue additional configuration option was added to store design configuration. As default, current behavior is kept, but this can be changed to not translate title, if needed.

Fixed Issues (if relevant)

  1. page.main.title is translating title #7065: page.main.title is translating title

Manual testing scenarios (*)

  1. Create a product with the name 'Save'
  2. Create a storeview that doesn't use english as locale (I'm using nl_NL as example)
  3. Change Translate Title option in Content -> Design -> Configuration to No, flush cache
  4. Go to the product detail page
  5. Page title should no longer be translated

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 5, 2020

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner labels Jan 5, 2020
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_7065_page_main_title_is_translating branch from 9337075 to 32f2e81 Compare January 5, 2020 14:24
@nuzil nuzil self-assigned this Jan 6, 2020
@nuzil nuzil added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Jan 6, 2020
nuzil
nuzil requested changes Jan 7, 2020
View reviewed changes
app/code/Magento/Theme/Block/Html/Title.php Outdated
ScopeConfigInterface $scopeConfig = null
) {
parent::__construct($context, $data);
$this->scopeConfig = $scopeConfig ?: ObjectManager::getInstance()->get(ScopeConfigInterface::class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we used such constructions to keep backward compatibility.
Currently we are delivering code in Magento 2.4.
So can you please, implement this without using of ObjectManager directly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuzil done

@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_7065_page_main_title_is_translating branch from 32f2e81 to 8fe06ff Compare January 7, 2020 08:53
@Bartlomiejsz Bartlomiejsz requested a review from nuzil January 7, 2020 08:53
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-6557 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jan 9, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jan 9, 2020
@ghost ghost added the Progress: accept label Jan 9, 2020
@Bartlomiejsz Bartlomiejsz mentioned this pull request Jan 16, 2020
Closed
4 tasks
@VladimirZaets VladimirZaets mentioned this pull request Jan 17, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jan 17, 2020
@VladimirZaets
ENGCOM-6557: Fix #7065 - page.main.title is translating title #26269
5bfadd7
@magento-engcom-team magento-engcom-team merged commit 8fe06ff into magento:2.4-develop Jan 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2020

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Bartlomiejsz Bartlomiejsz mentioned this pull request Feb 4, 2020
Merged
4 tasks
@Bartlomiejsz Bartlomiejsz mentioned this pull request Feb 13, 2020
Merged
4 tasks
@Bartlomiejsz Bartlomiejsz deleted the feature/fix_7065_page_main_title_is_translating branch September 19, 2020 09:58
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuzil nuzil nuzil approved these changes

@melnikovi melnikovi Awaiting requested review from melnikovi

Assignees

@nuzil nuzil

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Theme Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bartlomiejsz @magento-engcom-team @engcom-Delta @engcom-Foxtrot @nuzil