Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6310 - Changing products 'this item has weight' using 'Update Attributes' is not possible #26075

Merged
merged 3 commits into from
Mar 28, 2020
Merged

Fix #6310 - Changing products 'this item has weight' using 'Update Attributes' is not possible #26075

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2506c08
Fix #6310 - Changing products 'this item has weight' using 'Update At…
Bartlomiejsz Nov 26, 2019
f6f414b
Fix #6310 - set default value for weight switcher to 0
Bartlomiejsz Mar 20, 2020
36738ec
Fix #6310 - restore weight value check
Bartlomiejsz Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Weight.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function __construct(
$this->localeFormat = $localeFormat;
$this->weightSwitcher = $factoryElement->create('radios');
$this->weightSwitcher->setValue(
WeightResolver::HAS_WEIGHT
WeightResolver::HAS_NO_WEIGHT
)->setValues(
[
['value' => WeightResolver::HAS_WEIGHT, 'label' => __('Yes')],
Expand All @@ -84,10 +84,6 @@ public function __construct(
*/
public function getElementHtml()
{
if (!$this->getForm()->getDataObject()->getTypeInstance()->hasWeight()) {
$this->weightSwitcher->setValue(WeightResolver::HAS_NO_WEIGHT);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case you need to do the check opposite.

if ($this->getForm()->getDataObject()->getTypeInstance()->hasWeight()) {
$this->weightSwitcher->setValue(WeightResolver::HAS_WEIGHT);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check should be

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right @engcom-Echo, sorry for that. I restored this check

if ($this->getDisabled()) {
$this->weightSwitcher->setDisabled($this->getDisabled());
}
Expand Down